Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756896AbbDPJKd (ORCPT ); Thu, 16 Apr 2015 05:10:33 -0400 Received: from lb1-smtp-cloud3.xs4all.net ([194.109.24.22]:37499 "EHLO lb1-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753061AbbDPJKT (ORCPT ); Thu, 16 Apr 2015 05:10:19 -0400 Message-ID: <1429175408.16771.45.camel@x220> Subject: Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs From: Paul Bolle To: Matias =?ISO-8859-1?Q?Bj=F8rling?= Cc: hch@infradead.org, axboe@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, javier@paletta.io, keith.busch@intel.com Date: Thu, 16 Apr 2015 11:10:08 +0200 In-Reply-To: <1429101284-19490-3-git-send-email-m@bjorling.me> References: <1429101284-19490-1-git-send-email-m@bjorling.me> <1429101284-19490-3-git-send-email-m@bjorling.me> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1867 Lines: 79 A few things I spotted (while actually fiddling with 3/5). On Wed, 2015-04-15 at 14:34 +0200, Matias Bjørling wrote: > index f3dd028..58a8a71 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -221,6 +221,9 @@ static void blk_mq_rq_ctx_init(struct request_queue *q, struct blk_mq_ctx *ctx, > rq->end_io = NULL; > rq->end_io_data = NULL; > rq->next_rq = NULL; > +#if CONFIG_BLK_DEV_NVM I think you meant #ifdef CONFIG_BLK_DEV_NVM > + rq->phys_sector = 0; > +#endif > > ctx->rq_dispatched[rw_is_sync(rw_flags)]++; > } > --- /dev/null > +++ b/block/blk-nvm.c > +int nvm_register_target(struct nvm_target_type *tt) > +{ > + int ret = 0; > + > + down_write(&_lock); > + if (nvm_find_target_type(tt->name)) > + ret = -EEXIST; > + else > + list_add(&tt->list, &_targets); > + up_write(&_lock); > + > + return ret; > +} > + > +void nvm_unregister_target(struct nvm_target_type *tt) > +{ > + if (!tt) > + return; > + > + down_write(&_lock); > + list_del(&tt->list); > + up_write(&_lock); > +} Trying to build rrpc.ko I saw this WARNING: "nvm_unregister_target" [[...]/drivers/lightnvm/rrpc.ko] undefined! WARNING: "nvm_register_target" [[...]/drivers/lightnvm/rrpc.ko] undefined! So I guess you need to export these two functions too. > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -209,6 +209,9 @@ struct request { > > /* for bidi */ > struct request *next_rq; > +#if CONFIG_BLK_DEV_NVM Again, I think #ifdef CONFIG_BLK_DEV_NVM > + sector_t phys_sector; > +#endif > }; > > static inline unsigned short req_get_ioprio(struct request *req) Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/