Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933487AbbDPJb3 (ORCPT ); Thu, 16 Apr 2015 05:31:29 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:61695 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757140AbbDPJbQ (ORCPT ); Thu, 16 Apr 2015 05:31:16 -0400 From: Arnd Bergmann To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, stable@vger.kernel.org, Greg Kroah-Hartman , linux-serial@vger.kernel.org, Jiri Slaby Subject: Re: [PATCH v2] serial: of-serial: Remove device_type = "serial" registration Date: Thu, 16 Apr 2015 11:31:10 +0200 Message-ID: <3734018.A9aq7EmC6b@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:D683Fu40v7ago9R6CagRNGPHE/9Qr+6UV94bSllCrMZPWnynhHd UcOrIUbEPxmp/yD6H90B66gxM5anTIbArFkQbBXz26GKT+o0HMTaS+Is7HijxJHKzIvjBZO gh1SquYreL77kKIMvWFNAjpqVMXq+g9wAocb9PDEwb4YG3wVMte/X+NO+gGopumvD1FfyMM YC/jiEUV6cvdAlFa3ynRA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1220 Lines: 28 On Tuesday 14 April 2015 12:03:09 Michal Simek wrote: > Do not probe all serial drivers by of_serial.c which are using > device_type = "serial"; property. Only drivers which have valid > compatible strings listed in the driver should be probed. > > When PORT_UNKNOWN is setup probe will fail anyway. > > Arnd quotation about driver historical background: > "when I wrote that driver initially, the idea was that it would > get used as a stub to hook up all other serial drivers but after > that, the common code learned to create platform devices from DT" > > This patch fix the problem with on the system with xilinx_uartps and > 16550a where of_serial failed to register for xilinx_uartps and because > of irq_dispose_mapping() removed irq_desc. Then when xilinx_uartps was asking > for irq with request_irq() EINVAL is returned. > > Signed-off-by: Michal Simek > CC: > --- > Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/