Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S267488AbTALUCw>; Sun, 12 Jan 2003 15:02:52 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S267473AbTALUCv>; Sun, 12 Jan 2003 15:02:51 -0500
Received: from mta9.srv.hcvlny.cv.net ([167.206.5.133]:14054 "EHLO
	mta9.srv.hcvlny.cv.net") by vger.kernel.org with ESMTP
	id <S267488AbTALUCt>; Sun, 12 Jan 2003 15:02:49 -0500
Date: Sun, 12 Jan 2003 15:07:31 -0500
From: Rob Wilkens <robw@optonline.net>
Subject: Re: any chance of 2.6.0-test*?
In-reply-to: <3E21C8D5.5010301@blue-labs.org>
To: David Ford <david+cert@blue-labs.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Reply-to: robw@optonline.net
Message-id: <1042402051.3162.59.camel@RobsPC.RobertWilkens.com>
Organization: Robert Wilkens
MIME-version: 1.0
X-Mailer: Ximian Evolution 1.2.1
Content-type: text/plain
Content-transfer-encoding: 7BIT
References: <Pine.LNX.4.44.0301121100380.14031-100000@home.transmeta.com>
 <1042400094.1208.26.camel@RobsPC.RobertWilkens.com>
 <20030112194100.A15036@infradead.org>
 <1042400474.3162.32.camel@RobsPC.RobertWilkens.com>
 <3E21C8D5.5010301@blue-labs.org>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1392
Lines: 29

On Sun, 2003-01-12 at 14:58, David Ford wrote:
> The horrific response to the use of "goto" is deprecated in favor of 
> proper use.  A function overloaded with gotos probably should be 
> reworked.  But there there is no need to outright avoid the use of 
> 'goto'.  if()  is simply a conditional test with a goto A or goto B logic.

But if the if() is already there, there is no need to have an additional
goto in the statement,  My version may even be faster than linus'
version because it may save an extra assembler line of code (the beq or
whatever branch statement generated by the if would do the branch during
the if rather than after the if was evaluated and got to the first
statement which was the goto).  Of course, compiler optimizatoins
probably make that particular point pointless to discuss.

> There is a reason for the implementation of goto.  When it all boils 
> down to it, in assembler it's all a matter of JMP with or without a 
> condition.

But in this case, the condition was already there..  My point is that if
you don't need a goto, you shouldn't use it.  Whenever there's an
obvious way not to use it, don't.

-Rob

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/