Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757258AbbDPLke (ORCPT ); Thu, 16 Apr 2015 07:40:34 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:35015 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754212AbbDPLk0 (ORCPT ); Thu, 16 Apr 2015 07:40:26 -0400 Message-ID: <552F9F9E.3090007@dev.mellanox.co.il> Date: Thu, 16 Apr 2015 07:40:14 -0400 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: "ira.weiny" CC: Michael Wang , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Or Gerlitz , Haggai Eran , Tom Talpey , Jason Gunthorpe , Doug Ledford Subject: Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport() References: <552BB470.4090407@profitbricks.com> <552BB4FA.5000109@profitbricks.com> <552EAF9D.8050400@dev.mellanox.co.il> <20150415203332.GA15877@phlsvsds.ph.intel.com> In-Reply-To: <20150415203332.GA15877@phlsvsds.ph.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2102 Lines: 59 On 4/15/2015 4:33 PM, ira.weiny wrote: > On Wed, Apr 15, 2015 at 02:36:13PM -0400, Hal Rosenstock wrote: >> On 4/13/2015 8:22 AM, Michael Wang wrote: >>> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h >>> index 65994a1..d54f91e 100644 >>> --- a/include/rdma/ib_verbs.h >>> +++ b/include/rdma/ib_verbs.h >>> @@ -75,10 +75,13 @@ enum rdma_node_type { >>> }; >>> >>> enum rdma_transport_type { >>> + /* legacy for users */ >>> RDMA_TRANSPORT_IB, >>> RDMA_TRANSPORT_IWARP, >>> RDMA_TRANSPORT_USNIC, >>> - RDMA_TRANSPORT_USNIC_UDP >>> + RDMA_TRANSPORT_USNIC_UDP, >>> + /* new transport */ >>> + RDMA_TRANSPORT_IBOE, >>> }; >>> >>> __attribute_const__ enum rdma_transport_type >>> @@ -1501,6 +1504,8 @@ struct ib_device { >>> int (*query_port)(struct ib_device *device, >>> u8 port_num, >>> struct ib_port_attr *port_attr); >>> + enum rdma_transport_type (*query_transport)(struct ib_device *device, >>> + u8 port_num); >>> enum rdma_link_layer (*get_link_layer)(struct ib_device *device, >>> u8 port_num); >>> int (*query_gid)(struct ib_device *device, >> >> libibverbs also exposes transport at the device level. Isn't a change to >> make transport per port rather than per device needed there as well to >> be consistent with these proposed kernel changes ? If so, would the >> additional IBoE transport be exposed ? We also need to worry about >> backward compatibility for existing applications. > > Early on in this thread we agreed that user space would stay the same until we > get the kernel straightened out. I missed that in this very long thread. I just wanted to be sure that this will be addressed. -- Hal > The above enum and function are not exported > to user space so I believe this is in alignment with that plan. > > Ira > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/