Message-ID: <1429187895.7346.195.camel@edumazet-glaptop2.roam.corp.google.com>
Subject: Re: [PATCH] netns: deinline net_generic()
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: David Miller <davem@davemloft.net>, ebiederm@xmission.com,
        jengelh@medozas.de, jpirko@redhat.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Date: Thu, 16 Apr 2015 05:38:15 -0700
In-Reply-To: <552F9986.30207@redhat.com>
References: <1429014311-19868-1-git-send-email-dvlasenk@redhat.com>
	 <20150414.143747.1155055158701231768.davem@davemloft.net>
	 <552F9986.30207@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 847
Lines: 29

On Thu, 2015-04-16 at 13:14 +0200, Denys Vlasenko wrote:

> However, without BUG_ONs, function is still a bit big
> on PREEMPT configs.

Only on allyesconfig builds, that nobody use but to prove some points
about code size.

If you look at net_generic(), it is mostly used from code that is
normally in 3 modules. How many people really load them ?

net/tipc : 91 call sites
net/sunrpc : 57
fs/nfsd & fs/lockd : 183

Then few remaining uses in tunnels.

As we suggested, please just remove the BUG_ON().

Then, if you can come up with a solution that does not slow down non
PREEMPT kernel, why not.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/