Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757329AbbDPNIf (ORCPT ); Thu, 16 Apr 2015 09:08:35 -0400 Received: from axentia.se ([87.96.186.132]:37368 "EHLO EMAIL.axentia.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754789AbbDPNI3 convert rfc822-to-8bit (ORCPT ); Thu, 16 Apr 2015 09:08:29 -0400 From: Peter Rosin To: "weiyj_lk@163.com" , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai CC: Wei Yongjun , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ASoC: tfa9879: Fix return value check in tfa9879_i2c_probe() Thread-Topic: [PATCH] ASoC: tfa9879: Fix return value check in tfa9879_i2c_probe() Thread-Index: AQHQeEG7SfwDogiyQ06wwijWCbLWOJ1Pm90g Date: Thu, 16 Apr 2015 13:08:11 +0000 Message-ID: <1e7ee2f56f044e50acacf9481a9ee746@EMAIL.axentia.se> References: <1429186666-20547-1-git-send-email-weiyj_lk@163.com> In-Reply-To: <1429186666-20547-1-git-send-email-weiyj_lk@163.com> Accept-Language: en-US, sv-SE Content-Language: sv-SE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.210.101.82] x-gfi-smtp-submission: 1 x-gfi-smtp-hellodomain: EMAIL.axentia.se x-gfi-smtp-remoteip: 192.168.2.5 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 480 Lines: 15 Wei Yongjun wrote: > In case of error, the function devm_kzalloc() returns NULL not ERR_PTR(). > The IS_ERR() test in the return value check should be replaced with NULL > test. Acked-by: Peter Rosin Thanks, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/