Message-ID: <552FB94B.2090603@bjorling.me>
Date: Thu, 16 Apr 2015 15:29:47 +0200
From: =?UTF-8?B?TWF0aWFzIEJqw7hybGluZw==?= <m@bjorling.me>
Organization: Paletta
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Paul Bolle <pebolle@tiscali.nl>
CC: hch@infradead.org, axboe@fb.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
        javier@paletta.io, keith.busch@intel.com
Subject: Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs
References: <1429101284-19490-1-git-send-email-m@bjorling.me>		 <1429101284-19490-3-git-send-email-m@bjorling.me>	 <1429175408.16771.45.camel@x220> <552F8D84.8030504@bjorling.me> <1429184091.16771.60.camel@x220>
In-Reply-To: <1429184091.16771.60.camel@x220>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1527
Lines: 35

On 04/16/2015 01:34 PM, Paul Bolle wrote:
> On Thu, 2015-04-16 at 12:23 +0200, Matias Bjørling wrote:
>> On 04/16/2015 11:10 AM, Paul Bolle wrote:
>>> A few things I spotted (while actually fiddling with 3/5).
>>
>> Thanks. I'll fix them up.
>
> Please note that just using #ifdef instead of #if is not all that's
> needed. See, I had some fun playing whack-a-mole with warnings and
> errors showing up in the "CONFIG_BLK_DEV_NVM is not set" case (because I
> was looking into things outside of this series that I don't understand).
>
> After adding the changes pasted at the end of this message (which I gave
> almost no thought whatsoever) I ran into:
>      block/blk-mq.c: In function ‘blk_mq_init_rq_map’:
>      block/blk-mq.c:1473:22: error: invalid application of ‘sizeof’ to incomplete type ‘struct nvm_per_rq’
>         cmd_size += sizeof(struct nvm_per_rq);
>                            ^
>
> Then I admitted defeat.
>
> Have fun with your turn of that game.

Thanks. Nothing like a good whack-a-mole. I've fixed it up in the master at:

   https://github.com/OpenChannelSSD/linux.git

Keith, for the nvme driver, I've packed everything neatly into a #ifdef, 
so it looks the same as with the #ifdef integrity. It should have been 
like that from the start.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/