Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964928AbbDPNgm (ORCPT ); Thu, 16 Apr 2015 09:36:42 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:33138 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932203AbbDPNg3 (ORCPT ); Thu, 16 Apr 2015 09:36:29 -0400 Message-ID: <552FBAD6.6000400@dev.mellanox.co.il> Date: Thu, 16 Apr 2015 09:36:22 -0400 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: Michael Wang CC: Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Or Gerlitz , Haggai Eran , Ira Weiny , Tom Talpey , Jason Gunthorpe , Doug Ledford Subject: Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport() References: <552F6CF2.4000606@profitbricks.com> <552F6FB4.3060903@profitbricks.com> In-Reply-To: <552F6FB4.3060903@profitbricks.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2323 Lines: 71 On 4/16/2015 4:15 AM, Michael Wang wrote: > > We have get rid of all the scene using legacy rdma_node_get_transport(), > now clean it up. > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael Wang > --- > drivers/infiniband/core/verbs.c | 21 --------------------- > include/rdma/ib_verbs.h | 3 --- > 2 files changed, 24 deletions(-) > > diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c > index ee4b5cb..bbea0c0 100644 > --- a/drivers/infiniband/core/verbs.c > +++ b/drivers/infiniband/core/verbs.c > @@ -107,27 +107,6 @@ __attribute_const__ int ib_rate_to_mbps(enum ib_rate rate) > } > EXPORT_SYMBOL(ib_rate_to_mbps); > > -__attribute_const__ enum rdma_transport_type > -rdma_node_get_transport(enum rdma_node_type node_type) > -{ > - switch (node_type) { > - case RDMA_NODE_IB_CA: > - case RDMA_NODE_IB_SWITCH: > - case RDMA_NODE_IB_ROUTER: > - return RDMA_TRANSPORT_IB; > - case RDMA_NODE_RNIC: > - return RDMA_TRANSPORT_IWARP; > - case RDMA_NODE_USNIC: > - return RDMA_TRANSPORT_USNIC; > - case RDMA_NODE_USNIC_UDP: > - return RDMA_TRANSPORT_USNIC_UDP; > - default: > - BUG(); > - return 0; > - } > -} > -EXPORT_SYMBOL(rdma_node_get_transport); > - > enum rdma_link_layer rdma_port_get_link_layer(struct ib_device *device, u8 port_num) > { > if (device->get_link_layer) > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > index 262bf44..f9ef479 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -84,9 +84,6 @@ enum rdma_transport_type { > RDMA_TRANSPORT_IBOE, > }; > > -__attribute_const__ enum rdma_transport_type > -rdma_node_get_transport(enum rdma_node_type node_type); > - > enum rdma_link_layer { > IB_LINK_LAYER_UNSPECIFIED, Is IB_LINK_LAYER_UNSPECIFIED still possible ? > IB_LINK_LAYER_INFINIBAND, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/