Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933649AbbDPNpg (ORCPT ); Thu, 16 Apr 2015 09:45:36 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:37388 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933555AbbDPNp2 (ORCPT ); Thu, 16 Apr 2015 09:45:28 -0400 Message-ID: <552FBCF4.2070105@profitbricks.com> Date: Thu, 16 Apr 2015 15:45:24 +0200 From: Michael Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Hal Rosenstock CC: Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Or Gerlitz , Haggai Eran , Ira Weiny , Tom Talpey , Jason Gunthorpe , Doug Ledford Subject: Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport() References: <552F6CF2.4000606@profitbricks.com> <552F6FB4.3060903@profitbricks.com> <552FBAD6.6000400@dev.mellanox.co.il> <552FBBEC.3020606@profitbricks.com> <552FBC48.3010900@dev.mellanox.co.il> In-Reply-To: <552FBC48.3010900@dev.mellanox.co.il> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1661 Lines: 57 On 04/16/2015 03:42 PM, Hal Rosenstock wrote: > On 4/16/2015 9:41 AM, Michael Wang wrote: >> >> >> On 04/16/2015 03:36 PM, Hal Rosenstock wrote: >> [snip] >>>> -EXPORT_SYMBOL(rdma_node_get_transport); >>>> - >>>> enum rdma_link_layer rdma_port_get_link_layer(struct ib_device *device, u8 port_num) >>>> { >>>> if (device->get_link_layer) >>>> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h >>>> index 262bf44..f9ef479 100644 >>>> --- a/include/rdma/ib_verbs.h >>>> +++ b/include/rdma/ib_verbs.h >>>> @@ -84,9 +84,6 @@ enum rdma_transport_type { >>>> RDMA_TRANSPORT_IBOE, >>>> }; >>>> >>>> -__attribute_const__ enum rdma_transport_type >>>> -rdma_node_get_transport(enum rdma_node_type node_type); >>>> - >>>> enum rdma_link_layer { >>>> IB_LINK_LAYER_UNSPECIFIED, >>> >>> Is IB_LINK_LAYER_UNSPECIFIED still possible ? >> >> Actually it's impossible in kernel at first, all those who implemented the callback >> won't return UNSPECIFIED, others all have the correct transport type (otherwise BUG()) >> and won't result UNSPECIFIED :-) > > Should it be removed from this enum somewhere in this patch series > (perhaps early on) ? It was still directly used by helper like ib_modify_qp_is_ok() as indicator, may be better in another following patch to reform those part :-) Regards, Michael Wang > > -- Hal > >> Regards, >> Michael Wang >> >>> >>>> IB_LINK_LAYER_INFINIBAND, >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/