Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965125AbbDPNvG (ORCPT ); Thu, 16 Apr 2015 09:51:06 -0400 Received: from smtp.opengridcomputing.com ([72.48.136.20]:56173 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965060AbbDPNuy (ORCPT ); Thu, 16 Apr 2015 09:50:54 -0400 Message-ID: <552FBE48.2080104@opengridcomputing.com> Date: Thu, 16 Apr 2015 08:51:04 -0500 From: Tom Tucker User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Michael Wang , Hal Rosenstock CC: Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Or Gerlitz , Haggai Eran , Ira Weiny , Tom Talpey , Jason Gunthorpe , Doug Ledford Subject: Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport() References: <552F6CF2.4000606@profitbricks.com> <552F6FB4.3060903@profitbricks.com> <552FBAD6.6000400@dev.mellanox.co.il> <552FBBEC.3020606@profitbricks.com> <552FBC48.3010900@dev.mellanox.co.il> <552FBCF4.2070105@profitbricks.com> In-Reply-To: <552FBCF4.2070105@profitbricks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2020 Lines: 59 On 4/16/15 8:45 AM, Michael Wang wrote: > > On 04/16/2015 03:42 PM, Hal Rosenstock wrote: >> On 4/16/2015 9:41 AM, Michael Wang wrote: >>> >>> On 04/16/2015 03:36 PM, Hal Rosenstock wrote: >>> [snip] >>>>> -EXPORT_SYMBOL(rdma_node_get_transport); >>>>> - >>>>> enum rdma_link_layer rdma_port_get_link_layer(struct ib_device *device, u8 port_num) >>>>> { >>>>> if (device->get_link_layer) >>>>> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h >>>>> index 262bf44..f9ef479 100644 >>>>> --- a/include/rdma/ib_verbs.h >>>>> +++ b/include/rdma/ib_verbs.h >>>>> @@ -84,9 +84,6 @@ enum rdma_transport_type { >>>>> RDMA_TRANSPORT_IBOE, >>>>> }; >>>>> >>>>> -__attribute_const__ enum rdma_transport_type >>>>> -rdma_node_get_transport(enum rdma_node_type node_type); >>>>> - >>>>> enum rdma_link_layer { >>>>> IB_LINK_LAYER_UNSPECIFIED, >>>> Is IB_LINK_LAYER_UNSPECIFIED still possible ? >>> Actually it's impossible in kernel at first, all those who implemented the callback >>> won't return UNSPECIFIED, others all have the correct transport type (otherwise BUG()) >>> and won't result UNSPECIFIED :-) >> Should it be removed from this enum somewhere in this patch series >> (perhaps early on) ? I don't think it's ever been 'possible.' It's purpose is to catch initialized errors where the transport fails to initialize it's transport type. So for example, provider = calloc(1, sizeof *provider) If 0 is a valid link layer type, then you wouldn't catch these kinds of errors. Tom > It was still directly used by helper like ib_modify_qp_is_ok() as indicator, may be > better in another following patch to reform those part :-) > > Regards, > Michael Wang > >> -- Hal >> >>> Regards, >>> Michael Wang >>> >>>>> IB_LINK_LAYER_INFINIBAND, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/