Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757329AbbDPOQt (ORCPT ); Thu, 16 Apr 2015 10:16:49 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:36188 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754180AbbDPOQk (ORCPT ); Thu, 16 Apr 2015 10:16:40 -0400 Message-ID: <552FC441.5070500@dev.mellanox.co.il> Date: Thu, 16 Apr 2015 10:16:33 -0400 From: Hal Rosenstock User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: Or Gerlitz CC: Michael Wang , "Hefty, Sean" , Roland Dreier , Hal Rosenstock , "linux-rdma@vger.kernel.org" , Linux Kernel , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Or Gerlitz , Haggai Eran , Ira Weiny , Tom Talpey , Jason Gunthorpe , Doug Ledford Subject: Re: [PATCH v3 25/28] IB/Verbs: Use management helper cap_af_ib() References: <552BB470.4090407@profitbricks.com> <552BB801.2010506@profitbricks.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2953 Lines: 76 On 4/16/2015 9:57 AM, Or Gerlitz wrote: > On Mon, Apr 13, 2015 at 3:35 PM, Michael Wang wrote: >> >> Introduce helper cap_af_ib() to help us check if the port of an >> IB device support Native Infiniband Address. >> >> Cc: Steve Wise >> Cc: Tom Talpey >> Cc: Jason Gunthorpe >> Cc: Doug Ledford >> Cc: Ira Weiny >> Cc: Sean Hefty >> Signed-off-by: Michael Wang >> --- >> drivers/infiniband/core/cma.c | 2 +- >> include/rdma/ib_verbs.h | 15 +++++++++++++++ >> 2 files changed, 16 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c >> index 65e41f4..7f5815d 100644 >> --- a/drivers/infiniband/core/cma.c >> +++ b/drivers/infiniband/core/cma.c >> @@ -470,7 +470,7 @@ static int cma_resolve_ib_dev(struct rdma_id_private *id_priv) >> >> list_for_each_entry(cur_dev, &dev_list, list) { >> for (p = 1; p <= cur_dev->device->phys_port_cnt; ++p) { >> - if (!rdma_ib_or_iboe(cur_dev->device, p)) >> + if (!cap_af_ib(cur_dev->device, p)) >> continue; >> >> if (ib_find_cached_pkey(cur_dev->device, p, pkey, &index)) >> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h >> index 29ddd14..dfe33f3 100644 >> --- a/include/rdma/ib_verbs.h >> +++ b/include/rdma/ib_verbs.h >> @@ -1879,6 +1879,21 @@ static inline int cap_ipoib(struct ib_device *device, u8 port_num) >> } >> >> /** >> + * cap_af_ib - Check if the port of device has the capability >> + * Native Infiniband Address. >> + * >> + * @device: Device to be checked >> + * @port_num: Port number of the device >> + * >> + * Return 0 when port of the device don't support >> + * Native Infiniband Address. >> + */ >> +static inline int cap_af_ib(struct ib_device *device, u8 port_num) >> +{ >> + return rdma_ib_or_iboe(device, port_num); >> +} > > Sean, can you please put a precise writeup what does it take to > support AF_IB... I am a bit > confused here and wasn't sure if this can be supported with RoCE. I think this means IB GID addressing is checked (Native Infiniband Address) and not AF_IB (which is socket address/protocol family like INET and INET6). I think this naming is confusing and maybe cap_ib_gid is better ? -- Hal > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/