Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964880AbbDPPIm (ORCPT ); Thu, 16 Apr 2015 11:08:42 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:15519 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754219AbbDPPIc (ORCPT ); Thu, 16 Apr 2015 11:08:32 -0400 Message-ID: <552FD04C.2030507@atmel.com> Date: Thu, 16 Apr 2015 17:07:56 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Ludovic Desroches , , , CC: , , Subject: Re: [PATCH] tty/serial: at91: maxburst was missing for dma transfers References: <1429196292-8134-1-git-send-email-ludovic.desroches@atmel.com> In-Reply-To: <1429196292-8134-1-git-send-email-ludovic.desroches@atmel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1667 Lines: 45 Le 16/04/2015 16:58, Ludovic Desroches a ?crit : > Maxburst was not set when doing the dma slave configuration. This value > is checked by the recently introduced xdmac. It causes an error when > doing the slave configuration and so prevents from using dma. > > Signed-off-by: Ludovic Desroches > Cc: # 3.12 and later Indeed, thanks! Acked-by: Nicolas Ferre > --- > drivers/tty/serial/atmel_serial.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 4e959c4..6afce7e 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -880,6 +880,7 @@ static int atmel_prepare_tx_dma(struct uart_port *port) > config.direction = DMA_MEM_TO_DEV; > config.dst_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE; > config.dst_addr = port->mapbase + ATMEL_US_THR; > + config.dst_maxburst = 1; > > ret = dmaengine_slave_config(atmel_port->chan_tx, > &config); > @@ -1059,6 +1060,7 @@ static int atmel_prepare_rx_dma(struct uart_port *port) > config.direction = DMA_DEV_TO_MEM; > config.src_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE; > config.src_addr = port->mapbase + ATMEL_US_RHR; > + config.src_maxburst = 1; > > ret = dmaengine_slave_config(atmel_port->chan_rx, > &config); > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/