Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753771AbbDPQCk (ORCPT ); Thu, 16 Apr 2015 12:02:40 -0400 Received: from mout.perfora.net ([74.208.4.194]:59226 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbbDPQCb convert rfc822-to-8bit (ORCPT ); Thu, 16 Apr 2015 12:02:31 -0400 From: "James R. Bergsten" To: "'Keith Busch'" , "=?utf-8?Q?'Javier_Gonz=C3=A1lez'?=" Cc: , "=?utf-8?Q?'Matias_Bj=C3=B8rling'?=" , , , , References: <1429101284-19490-1-git-send-email-m@bjorling.me> <1429101284-19490-6-git-send-email-m@bjorling.me> <694D3575-E49B-45BB-8E48-7188169B75F0@paletta.io> In-Reply-To: Subject: RE: [PATCH 5/5 v2] nvme: LightNVM support Date: Thu, 16 Apr 2015 09:01:35 -0700 Message-ID: <057301d0785e$9f8e81c0$deab8540$@thebergstens.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQJWYaS6wpbzH6LQfuMvF+cknPf/7wFNVdyGASSU5j0B3yo6ogHR5LPonBLhy6A= Content-Language: en-us X-Provags-ID: V03:K0:+d26ZL400wuDP8cBmKD5Hn/JCpKktw8qnq0zur29oz/3qiS/fqy pG53GlEfdHn9ZpDPy3sSwiqn7p7rhfCWAQ2/wvS+3L24FLUxs+bpqXQR6MbJgGB+E+Sj5Ci 3fJzcEOrQBWlSBVIu1jhnqS1/zEKNLK83A1DvnQ3Pj4fxfiKt83K5x+OTFiRCeGlUB2Gv9C zq5Gp7IZbbwfL75uyFc4A== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1400 Lines: 27 My two cents worth is that it's (always) better to put ALL the commands into one place so that the entire set can be viewed at once and thus avoid inadvertent overloading of an opcode. Otherwise you don't know what you don't know. -----Original Message----- From: Linux-nvme [mailto:linux-nvme-bounces@lists.infradead.org] On Behalf Of Keith Busch Sent: Thursday, April 16, 2015 8:52 AM To: Javier González Cc: hch@infradead.org; Matias Bjørling; axboe@fb.com; linux-kernel@vger.kernel.org; linux-nvme@lists.infradead.org; Keith Busch; linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 5/5 v2] nvme: LightNVM support On Thu, 16 Apr 2015, Javier González wrote: >> On 16 Apr 2015, at 16:55, Keith Busch wrote: >> >> Otherwise it looks pretty good to me, but I think it would be cleaner >> if the lightnvm stuff is not mixed in the same file with the standard >> nvme command set. We might end up splitting nvme-core in the future >> anyway for command sets and transports. > > Would you be ok with having nvme-lightnvm for LightNVM specific > commands? Sounds good to me, but I don't really have a dog in this fight. :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/