Date: Thu, 16 Apr 2015 10:43:11 -0600
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Michael Wang <yun.wang@profitbricks.com>
Cc: Roland Dreier <roland@kernel.org>, Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org, Tom Tucker <tom@opengridcomputing.com>,
        Steve Wise <swise@opengridcomputing.com>,
        Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
        Christoph Raisch <raisch@de.ibm.com>,
        Mike Marciniszyn <infinipath@intel.com>, Eli Cohen <eli@mellanox.com>,
        Faisal Latif <faisal.latif@intel.com>,
        Jack Morgenstein <jackm@dev.mellanox.co.il>,
        Or Gerlitz <ogerlitz@mellanox.com>, Haggai Eran <haggaie@mellanox.com>,
        Ira Weiny <ira.weiny@intel.com>, Tom Talpey <tom@talpey.com>,
        Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe()
Message-ID: <20150416164311.GB22946@obsidianresearch.com>
References: <552BB470.4090407@profitbricks.com>
 <552BB85D.7010400@profitbricks.com>
 <20150413203350.GA20611@obsidianresearch.com>
 <552CDA1F.4050609@profitbricks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <552CDA1F.4050609@profitbricks.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 944
Lines: 23

On Tue, Apr 14, 2015 at 11:13:03AM +0200, Michael Wang wrote:

> > I would be very happy to see a patch that adds cap_ib_smi to the
> > current tree and states 'This patch is tested to have no change on the
> > binary compilation results'
> 
> There are too much reform there (per-dev to per-port), I guess the binary
> will changed more or less anyway...

I think this patch series is huge, and everytime someone new looks at
it small functional errors seem to pop up..

Doing something to reduce the review surface would be really helpful
here. Not changing the same line twice, using tools too perform these
transforms and then assert the patch is a NOP because .. tools. Some
other idea?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/