Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754080AbbDPRFt (ORCPT ); Thu, 16 Apr 2015 13:05:49 -0400 Received: from mga11.intel.com ([192.55.52.93]:3506 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753423AbbDPRFf convert rfc822-to-8bit (ORCPT ); Thu, 16 Apr 2015 13:05:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,589,1422950400"; d="scan'208";a="714812896" From: "Weiny, Ira" To: Jason Gunthorpe , Michael Wang CC: "Hefty, Sean" , Roland Dreier , Hal Rosenstock , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Tom Tucker , "Steve Wise" , Hoang-Nam Nguyen , Christoph Raisch , infinipath , "Eli Cohen" , "Latif, Faisal" , "Jack Morgenstein" , Or Gerlitz , Haggai Eran , Tom Talpey , "Doug Ledford" Subject: RE: [PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib Thread-Topic: [PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib Thread-Index: AQHQdeT3tD4bfTZ72k699JaOjshv/p1LuGyA//+guwCAAGjxAIAAzcQAgACY34D//6BugIAAaQUAgAABCoCAAAVDgIAA5C4AgAIlSwD//5+mgA== Date: Thu, 16 Apr 2015 17:05:31 +0000 Message-ID: <2807E5FD2F6FDA4886F6618EAC48510E0CC8BFFA@CRSMSX101.amr.corp.intel.com> References: <20150413192701.GA19112@obsidianresearch.com> <20150413194602.GA21467@phlsvsds.ph.intel.com> <20150413200138.GC19112@obsidianresearch.com> <20150414141806.GA7354@phlsvsds.ph.intel.com> <20150414172514.GB7682@obsidianresearch.com> <20150414174311.GA28111@phlsvsds.ph.intel.com> <20150414175904.GB13896@obsidianresearch.com> <1828884A29C6694DAF28B7E6B8A82373A8FC127C@ORSMSX109.amr.corp.intel.com> <20150414182137.GD7682@obsidianresearch.com> <552E1A1A.4090704@profitbricks.com> <20150416164418.GC22946@obsidianresearch.com> In-Reply-To: <20150416164418.GC22946@obsidianresearch.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.18.205.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 25 > > On Wed, Apr 15, 2015 at 09:58:18AM +0200, Michael Wang wrote: > > > We can give client->add() callback a return value and make > > ib_register_device() return -ENOMEM when it failed, just wondering why > > we don't do this at first, any special reason? > > No idea, but having ib_register_device fail and unwind if a client fails to attach > makes sense to me. Yes that is what we should do _but_ I think we should tackle that in a different series. As you said in another email, this series is getting very long and hard to review/prove is correct. This is why I was advocating keeping a check at the top of cm_add_one which verified all Ports supported the CM. This is the current logic today and is proven to work for the devices/use cases out there. We can clean up the initialization code and implement support for individual ports in follow on patches. Ira -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/