Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755306AbbDPRbR (ORCPT <rfc822;w@1wt.eu>);
	Thu, 16 Apr 2015 13:31:17 -0400
Received: from mga01.intel.com ([192.55.52.88]:65370 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752805AbbDPRbL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 16 Apr 2015 13:31:11 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,589,1422950400"; 
   d="scan'208";a="696412466"
From: "Hefty, Sean" <sean.hefty@intel.com>
To: Tom Talpey <tom@talpey.com>, Michael Wang <yun.wang@profitbricks.com>,
        "Hal Rosenstock" <hal@dev.mellanox.co.il>
CC: Roland Dreier <roland@kernel.org>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Tom Tucker <tom@opengridcomputing.com>,
        "Steve Wise" <swise@opengridcomputing.com>,
        Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
        Christoph Raisch <raisch@de.ibm.com>,
        infinipath <infinipath@intel.com>, "Eli Cohen" <eli@mellanox.com>,
        "Latif, Faisal" <faisal.latif@intel.com>,
        "Jack Morgenstein" <jackm@dev.mellanox.co.il>,
        Or Gerlitz <ogerlitz@mellanox.com>, Haggai Eran <haggaie@mellanox.com>,
        "Weiny, Ira" <ira.weiny@intel.com>,
        "Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>,
        Doug Ledford <dledford@redhat.com>
Subject: RE: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core
 cma/ucm
Thread-Topic: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core
 cma/ucm
Thread-Index: AQHQeByESK9SrXF5gUqrmqf2oexT451QEpgAgAACiID//52zoIAAhKQAgAAhTAD//4vFQA==
Date: Thu, 16 Apr 2015 17:30:34 +0000
Message-ID: <1828884A29C6694DAF28B7E6B8A82373A8FC2508@ORSMSX109.amr.corp.intel.com>
References: <552F6CF2.4000606@profitbricks.com>
 <552F6DEA.9080701@profitbricks.com> <552FB4D0.5080302@dev.mellanox.co.il>
 <552FB6EF.80107@profitbricks.com>
 <1828884A29C6694DAF28B7E6B8A82373A8FC22C3@ORSMSX109.amr.corp.intel.com>
 <552FD3BE.4090204@profitbricks.com> <552FEFAC.6080402@talpey.com>
In-Reply-To: <552FEFAC.6080402@talpey.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.22.254.139]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id t3GHVLv5023223
Content-Length: 955
Lines: 29

> > To be confirmed:
> > 				PORT ASSIGNED
> > 	rdma_init_qp_attr	Y
> > 	rdma_destroy_id		unknown
> > 	cma_listen_on_dev	N
> > 	cma_bind_loopback	N

Bind loopback will attach to a port, but the id does not have on entry.

> > 	rdma_listen		N
> 
> Why "N"? rdma_listen() can be constrained to a single port, right?
> And even if wildcarded, it needs to act on multiple ports, which is
> to say, it will fail only if no ports are eligible.

Rdma listen should be unknown.  The id may be assigned to a port.  It depends on the source address.

> > 	rdma_connect		Y
> > 	rdma_accept		Y
> > 	rdma_reject		Y
> > 	rdma_disconnect		Y
> > 	ib_ucm_add_one		N

Others look correct.

Btw, thanks for your work on this.  I know this is becoming a much bigger change than you originally intended.  :)

- Sean
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?