Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754175AbbDPSOn (ORCPT ); Thu, 16 Apr 2015 14:14:43 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:34533 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753611AbbDPSO3 (ORCPT ); Thu, 16 Apr 2015 14:14:29 -0400 Date: Thu, 16 Apr 2015 14:14:27 -0400 (EDT) Message-Id: <20150416.141427.1085248733060476395.davem@davemloft.net> To: pure.logic@nexus-software.ie Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org, andriy.shevchenko@linux.intel.com, hock.leong.kweh@intel.com, boon.leong.ong@intel.com, dan.odonovan@emutex.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/1] stmmac: fix oops on rmmod after assigning ip addr From: David Miller In-Reply-To: <1429203363-10919-2-git-send-email-pure.logic@nexus-software.ie> References: <1429203363-10919-1-git-send-email-pure.logic@nexus-software.ie> <1429203363-10919-2-git-send-email-pure.logic@nexus-software.ie> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 16 Apr 2015 11:14:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 807 Lines: 23 From: Bryan O'Donoghue Date: Thu, 16 Apr 2015 17:56:03 +0100 > An oops exists in the flow of stmmac_release(). > phy_ethtool_get_wol() depends on phydev->drv. > phydev->drv will be null after stmmac_mdio_unreg() completes. > > Steps to reproduce on Quark X1000: > > 1. ifconfig eth0 192.168.0.1 > 2. rmmod stmmac_pci > > To fix this stmmac_mdio_unreg() should be run after unregister_netdev(). > > Signed-off-by: Bryan O'Donoghue > Reported-by: Dan O'Donovan Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/