Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754858AbbDPSqH (ORCPT ); Thu, 16 Apr 2015 14:46:07 -0400 Received: from casper.infradead.org ([85.118.1.10]:44921 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752200AbbDPSp4 (ORCPT ); Thu, 16 Apr 2015 14:45:56 -0400 Date: Thu, 16 Apr 2015 20:45:44 +0200 From: Peter Zijlstra To: Kan Liang Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, acme@infradead.org, eranian@google.com, andi@firstfloor.org Subject: Re: [PATCH V6 3/6] perf, x86: large PEBS interrupt threshold Message-ID: <20150416184544.GB23123@twins.programming.kicks-ass.net> References: <1428597466-8154-1-git-send-email-kan.liang@intel.com> <1428597466-8154-4-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428597466-8154-4-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 785 Lines: 21 On Thu, Apr 09, 2015 at 12:37:43PM -0400, Kan Liang wrote: > + /* > + * When the event is constrained enough we can use a larger > + * threshold and run the event with less frequent PMI. > + */ > + if (0 && /* disable this temporarily */ This is a good hint your patches are ordered wrong. > + (hwc->flags & PERF_X86_EVENT_AUTO_RELOAD)) { > + threshold = ds->pebs_absolute_maximum - > + x86_pmu.max_pebs_events * x86_pmu.pebs_record_size; > + } else { > + threshold = ds->pebs_buffer_base + x86_pmu.pebs_record_size; > + } > + -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/