Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754958AbbDPS4D (ORCPT ); Thu, 16 Apr 2015 14:56:03 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:34109 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754470AbbDPSzy (ORCPT ); Thu, 16 Apr 2015 14:55:54 -0400 Message-ID: <553005B5.9000101@cogentembedded.com> Date: Thu, 16 Apr 2015 21:55:49 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Vivien Didelot , netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org, "David S. Miller" , Guenter Roeck , Florian Fainelli , kernel@savoirfairelinux.com Subject: Re: [PATCH 1/2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max References: <1429209499-2447-1-git-send-email-vivien.didelot@savoirfairelinux.com> In-Reply-To: <1429209499-2447-1-git-send-email-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 857 Lines: 26 Hello. On 04/16/2015 09:38 PM, Vivien Didelot wrote: > Since commit da4759c, sysfs will only use the permissions returned by Please also specify that commit's summary line in parens. > is_visible, instead of OR'ing them with the default file mode. > This allows us to declare temp1_max with the DEVICE_ATTR_RW macro and > just return the desired permissions for the hwmon sysfs attributes in > dsa_hwmon_attrs_visible. > Also, allow temp1_max to be write-only if set_temp_limit is provided, > but not get_temp_limit. > Signed-off-by: Vivien Didelot WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/