Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752565AbbDPTUx (ORCPT ); Thu, 16 Apr 2015 15:20:53 -0400 Received: from g9t5009.houston.hp.com ([15.240.92.67]:37006 "EHLO g9t5009.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072AbbDPTUn (ORCPT ); Thu, 16 Apr 2015 15:20:43 -0400 Message-ID: <1429210917.17259.5.camel@misato.fc.hp.com> Subject: Re: [PATCH] ACPI / scan: Annotate physical_node_lock in acpi_scan_is_offline() From: Toshi Kani To: "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, Xie XiuQi , guohanjun@huawei.com, hanjun.guo@linaro.org, linux-kernel@vger.kernel.org Date: Thu, 16 Apr 2015 13:01:57 -0600 In-Reply-To: <2181841.0nPiIAbDNm@vostro.rjw.lan> References: <1428397392-26200-1-git-send-email-xiexiuqi@huawei.com> <5219717.RxvSXtBaZ8@vostro.rjw.lan> <12760195.2odgqTkKju@vostro.rjw.lan> <2181841.0nPiIAbDNm@vostro.rjw.lan> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 873 Lines: 25 On Sat, 2015-04-11 at 01:31 +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > acpi_scan_is_offline() may be called under the physical_node_lock > of the given device object's parent, so prevent lockdep from > complaining about that by annotating that instance with > SINGLE_DEPTH_NESTING. > > Reported-by: Xie XiuQi > Signed-off-by: Rafael J. Wysocki Agreed that the issue is likely with the lock-class. Assuming Xie's test goes well (we will need to wait for that :), Reviewed-by: Toshi Kani Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/