Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753772AbbDPV1T (ORCPT ); Thu, 16 Apr 2015 17:27:19 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:58411 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751650AbbDPV1F (ORCPT ); Thu, 16 Apr 2015 17:27:05 -0400 Date: Thu, 16 Apr 2015 14:26:38 -0700 From: Guenter Roeck To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Florian Fainelli , kernel@savoirfairelinux.com Subject: Re: [PATCH 2/2] net: dsa: register hwmon for any provided function Message-ID: <20150416212638.GB2587@roeck-us.net> References: <1429209499-2447-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1429209499-2447-2-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429209499-2447-2-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020203.55302929.003A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 9 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1835 Lines: 55 On Thu, Apr 16, 2015 at 02:38:19PM -0400, Vivien Didelot wrote: > A switch driver may only provide one of the temperature limit accessors, > or the temperature alarm getter. So register the hwmon subsystem if any > of the related functions is provided. > > Thus, check get_temp to set the visibility of temp1_input. > > Signed-off-by: Vivien Didelot > --- > net/dsa/dsa.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c > index 67d2983..6b68994 100644 > --- a/net/dsa/dsa.c > +++ b/net/dsa/dsa.c > @@ -157,6 +157,10 @@ static umode_t dsa_hwmon_attrs_visible(struct kobject *kobj, > umode_t mode = 0; > > switch (index) { > + case 0: /* temp1_input */ > + if (drv->get_temp) > + mode |= S_IRUGO; This should be mandatory. Sorry, I don't really understand what you are trying to accomplish here. Can you give me a real world example where a chip would support setting a limit but not reading it ? Thanks, Guenter > + break; > case 1: /* temp1_max */ > if (drv->get_temp_limit) > mode |= S_IRUGO; > @@ -310,7 +314,8 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent) > * register with hardware monitoring subsystem. > * Treat registration error as non-fatal and ignore it. > */ > - if (drv->get_temp) { > + if (drv->get_temp || drv->get_temp_limit || drv->set_temp_limit || > + drv->get_temp_alarm) { > const char *netname = netdev_name(dst->master_netdev); > char hname[IFNAMSIZ + 1]; > int i, j; > -- > 2.3.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/