Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958AbbDPVev (ORCPT ); Thu, 16 Apr 2015 17:34:51 -0400 Received: from mga09.intel.com ([134.134.136.24]:58447 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856AbbDPVer (ORCPT ); Thu, 16 Apr 2015 17:34:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,590,1422950400"; d="scan'208";a="696521225" Message-ID: <55302AF3.1010901@linux.intel.com> Date: Fri, 17 Apr 2015 05:34:43 +0800 From: "Jin, Yao" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jarkko Nikula , weiyj_lk@163.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.de, dan.carpenter@oracle.com, pawel.piskorski@intel.com, yang.jie@intel.com, han.lu@intel.com CC: Wei Yongjun , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH -next] ASoC: Intel: sst_hsw: remove kfree for memory allocated with devm_kzalloc References: <1429191978-25839-1-git-send-email-weiyj_lk@163.com> <552FC268.2020503@linux.intel.com> In-Reply-To: <552FC268.2020503@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 47 For HSW, a patch "[PATCH] ASoC: Intel: Remove invalid kfree of devm allocated data" to fix this issue has been applied. But yes, we also need a similar patch for Baytrail. Thanks Jin Yao On 2015/4/16 22:08, Jarkko Nikula wrote: > On 04/16/2015 04:46 PM, weiyj_lk@163.com wrote: >> From: Wei Yongjun >> >> It's not necessary to free memory allocated with devm_kzalloc >> and using kfree leads to a double free. >> >> Signed-off-by: Wei Yongjun >> --- >> sound/soc/intel/haswell/sst-haswell-ipc.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c >> b/sound/soc/intel/haswell/sst-haswell-ipc.c >> index 344a1e9..324eceb 100644 >> --- a/sound/soc/intel/haswell/sst-haswell-ipc.c >> +++ b/sound/soc/intel/haswell/sst-haswell-ipc.c >> @@ -2201,7 +2201,6 @@ dma_err: >> dsp_new_err: >> sst_ipc_fini(ipc); >> ipc_init_err: >> - kfree(hsw); >> return ret; >> } >> EXPORT_SYMBOL_GPL(sst_hsw_dsp_init); >> > Similar case than with baytrail. Here introduced by commit 0e7921e9583b > ("ASoC: Intel: Use the generic IPC/mailbox APIs in Broadwell") > > Reviewed-by: Jarkko Nikula > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/