Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753606AbbDPWFv (ORCPT ); Thu, 16 Apr 2015 18:05:51 -0400 Received: from mail.savoirfairelinux.com ([209.172.62.77]:63238 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbbDPWFl (ORCPT ); Thu, 16 Apr 2015 18:05:41 -0400 Date: Thu, 16 Apr 2015 18:05:39 -0400 (EDT) From: Vivien Didelot To: Guenter Roeck Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Florian Fainelli , kernel@savoirfairelinux.com Message-ID: <973411308.896485.1429221939679.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: <20150416212638.GB2587@roeck-us.net> References: <1429209499-2447-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1429209499-2447-2-git-send-email-vivien.didelot@savoirfairelinux.com> <20150416212638.GB2587@roeck-us.net> Subject: Re: [PATCH 2/2] net: dsa: register hwmon for any provided function MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.0.9_GA_6191 (ZimbraWebClient - FF37 (Linux)/8.0.9_GA_6191) Thread-Topic: register hwmon for any provided function Thread-Index: AMJOTSz/eoEz961mSTc6FSGWUppAww== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 987 Lines: 27 Hi Guenter, > > switch (index) { > > + case 0: /* temp1_input */ > > + if (drv->get_temp) > > + mode |= S_IRUGO; > > This should be mandatory. Sorry, I don't really understand what you are > trying to accomplish here. > > Can you give me a real world example where a chip would support setting > a limit but not reading it ? I have no such example. I just did not see why this couldn't be allowed (e.g. setting only set_temp_limit and get_temp_alarm looks fine to me). But if you say that get_temp should be mandatory, I'm OK with that. The primary goal of this patchset was to use DEVICE_ATTR_RW to declare temp1_max, instead of reflecting the minimal permissions needed. Best, -v -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/