Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S267547AbTALWJp>; Sun, 12 Jan 2003 17:09:45 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S267552AbTALWJp>; Sun, 12 Jan 2003 17:09:45 -0500
Received: from vitelus.com ([64.81.243.207]:59920 "EHLO vitelus.com")
	by vger.kernel.org with ESMTP id <S267547AbTALWJo>;
	Sun, 12 Jan 2003 17:09:44 -0500
Date: Sun, 12 Jan 2003 14:18:02 -0800
From: Aaron Lehmann <aaronl@vitelus.com>
To: Rob Wilkens <robw@optonline.net>
Cc: Rik van Riel <riel@conectiva.com.br>,
       Matti Aarnio <matti.aarnio@zmailer.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: any chance of 2.6.0-test*?
Message-ID: <20030112221802.GN31238@vitelus.com>
References: <Pine.LNX.4.44.0301121100380.14031-100000@home.transmeta.com> <1042400094.1208.26.camel@RobsPC.RobertWilkens.com> <20030112211530.GP27709@mea-ext.zmailer.org> <1042406849.3162.121.camel@RobsPC.RobertWilkens.com> <Pine.LNX.4.50L.0301121939170.26759-100000@imladris.surriel.com> <1042407845.3162.131.camel@RobsPC.RobertWilkens.com> <20030112214937.GM31238@vitelus.com> <1042409239.3162.136.camel@RobsPC.RobertWilkens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1042409239.3162.136.camel@RobsPC.RobertWilkens.com>
User-Agent: Mutt/1.5.3i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1047
Lines: 18

On Sun, Jan 12, 2003 at 05:07:19PM -0500, Rob Wilkens wrote:
> In the case of an inline function, you're saving a jump, because the
> code that you would "goto" is right there in sequence with the code you
> are executing as far as the processor is concerned.  In essence, you're
> duplicating code, but you're not retyping code, and your keeping code
> consistent accross all uses of it (keeping it modular).

These are usually error conditions. If you inline them, you will have
to jump *over* them as part of the normal code path. You don't save
any instructions, and you end up with a kernel which has much more
duplicated code and thus thrashes the cache more. It also makes the
code harder to read. goto makes it easy "stack" error handlers and not
worry about the order in which you do clean up.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/