Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753121AbbDQHcx (ORCPT ); Fri, 17 Apr 2015 03:32:53 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:35489 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbbDQHco (ORCPT ); Fri, 17 Apr 2015 03:32:44 -0400 Message-ID: <5530B713.8020106@ti.com> Date: Fri, 17 Apr 2015 10:32:35 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Peter Chen CC: , , , , , , , , , Subject: Re: [RFC][PATCH v2 08/13] usb: otg: hub: Notify OTG fsm when A device sets b_hnp_enable References: <1429008120-5395-1-git-send-email-rogerq@ti.com> <1429008120-5395-9-git-send-email-rogerq@ti.com> <20150417022814.GC13764@shlinux2> In-Reply-To: <20150417022814.GC13764@shlinux2> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2476 Lines: 74 On 17/04/15 05:28, Peter Chen wrote: > On Tue, Apr 14, 2015 at 01:41:55PM +0300, Roger Quadros wrote: >> This is the a_set_b_hnp_enable flag in the OTG state machine >> diagram and must be set when the A-Host has successfully set >> the b_hnp_enable feature of the OTG-B-Peripheral attached to it. >> >> When this bit changes we kick our OTG FSM to make note of the >> change and act accordingly. >> >> Signed-off-by: Roger Quadros >> --- >> drivers/usb/core/hub.c | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c >> index d7c3d5a..ab0d498 100644 >> --- a/drivers/usb/core/hub.c >> +++ b/drivers/usb/core/hub.c >> @@ -22,6 +22,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -2270,6 +2271,9 @@ static int usb_enumerate_device_otg(struct usb_device *udev) >> "can't set HNP mode: %d\n", >> err); >> bus->b_hnp_enable = 0; >> + } else { >> + /* notify OTG fsm about a_set_b_hnp_enable */ >> + usb_otg_kick_fsm(udev->bus->controller); >> } >> } >> } >> @@ -4244,8 +4248,13 @@ hub_port_init (struct usb_hub *hub, struct usb_device *udev, int port1, >> */ >> if (!hdev->parent) { >> delay = HUB_ROOT_RESET_TIME; >> - if (port1 == hdev->bus->otg_port) >> + if (port1 == hdev->bus->otg_port) { >> hdev->bus->b_hnp_enable = 0; >> +#ifdef CONFIG_USB_OTG >> + /* notify OTG fsm about a_set_b_hnp_enable change */ >> + usb_otg_kick_fsm(hdev->bus->controller); >> +#endif >> + } >> } >> >> /* Some low speed devices have problems with the quick delay, so */ >> -- >> 2.1.0 >> > > Since the fsm has already kicked, the only thing we need is update > fsm.a_set_b_hnp_enable, but this flag is missing at current fsm > structure. Every time the input changes, the fsm has to be re-kicked. Instead of fsm.a_set_b_hnp_enable we use fsm->otg->host->b_hnp_enable in the fsm. USB host stack doesn't have access to fsm structure but the OTG state machine has access to hcd. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/