Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbbDQIJx (ORCPT ); Fri, 17 Apr 2015 04:09:53 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:38969 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbbDQIJl (ORCPT ); Fri, 17 Apr 2015 04:09:41 -0400 Date: Fri, 17 Apr 2015 09:09:37 +0100 From: Charles Keepax To: lee.jones@linaro.org Cc: patches@opensource.wolfsonmicro.com, broonie@kernel.org, sameo@linux.intel.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com Subject: Re: [PATCH 5/9] mfd: wm5110: Add register patch required for low power sleep Message-ID: <20150417080937.GB3480@opensource.wolfsonmicro.com> References: <1428508578-21022-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1428508578-21022-6-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428508578-21022-6-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2041 Lines: 61 On Wed, Apr 08, 2015 at 04:56:14PM +0100, Charles Keepax wrote: > Some register settings must be applied before the first time low power > sleep mode is entered on the wm5110 to ensure optimium performance. > These settings require SYSCLK to be enabled whilst they are being > applied. This patch applies the settings using the recently factored out > boot time SYSCLK functionality. > > Signed-off-by: Charles Keepax > Acked-by: Lee Jones > --- > drivers/mfd/arizona-core.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 42 insertions(+), 0 deletions(-) > > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index f1d9ef0..745ee6c 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -405,6 +405,38 @@ static int wm5102_clear_write_sequencer(struct arizona *arizona) > return 0; > } > > +/* > + * Register patch to some of the CODECs internal write sequences > + * to ensure a clean exit from the low power sleep state. > + */ > +static const struct reg_default wm5110_sleep_patch[] = { > + { 0x337A, 0xC100 }, > + { 0x337B, 0x0041 }, > + { 0x3300, 0xA210 }, > + { 0x3301, 0x050C }, > +}; > + > +static int wm5110_apply_sleep_patch(struct arizona *arizona) > +{ > + struct arizona_sysclk_state state; > + int err, ret; > + > + ret = arizona_enable_freerun_sysclk(arizona, &state); > + if (ret) > + return ret; > + > + ret = regmap_multi_reg_write_bypassed(arizona->regmap, > + wm5110_sleep_patch, > + ARRAY_SIZE(wm5110_sleep_patch)); > + > + err = arizona_disable_freerun_sysclk(arizona, &state); > + > + if (ret) > + return ret; > + else > + return err; Sorry this should also be a ternary, will do a new spin. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/