Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753708AbbDQIMV (ORCPT ); Fri, 17 Apr 2015 04:12:21 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:30723 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753463AbbDQIMK (ORCPT ); Fri, 17 Apr 2015 04:12:10 -0400 Date: Fri, 17 Apr 2015 11:11:34 +0300 From: Dan Carpenter To: Alan Cox Cc: Geert Uytterhoeven , Peter Senna Tschudin , driverdevel , Greg Kroah-Hartman , Jun Tian , "linux-kernel@vger.kernel.org" , Andreas , Garret Kelly , Octavian Purdila , Nick Kralevich Subject: Re: [PATCH V4] Fix pointer cast for 32 bits arch Message-ID: <20150417081134.GN10964@mwanda> References: <20150413122911.GW10964@mwanda> <1429191546-1398-1-git-send-email-peter.senna@gmail.com> <20150416170144.GM10964@mwanda> <1429203927.2878.238.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429203927.2878.238.camel@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1277 Lines: 37 On Thu, Apr 16, 2015 at 06:05:27PM +0100, Alan Cox wrote: > Its a 64 on 64 or 32 on 32 virtual machine. Goldfish is used for Android > emulation for all the system level phone emulation tools. On the > emulation side it provides an interface for the emulated OS but makes no > effort to emulate it as if it was a real hardware. If you think of it as > a funky emulator interface all is good. If you think about it as > "hardware" you've got the wrong model and chunks of Goldfish make less > sense. > Ah. Ok. That makes sense. Peter maybe the fix is to make a different function: static inline void gf_write_dma_addr(dma_addr_t addr, void __iomem *portl, void __iomem *porth) { writel((u32)data, portl); #ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT writel(data >> 32, porth); #endif } Something like that. The gf_write_ptr() function patch you wrote preserves the current behavior, but the current behavior is buggy, (I think) so we need both gf_write_dma_addr() and gf_write_ptr(). regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/