Date: Fri, 17 Apr 2015 11:20:17 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>, driverdevel <devel@driverdev.osuosl.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jun Tian <jun.j.tian@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Garret Kelly <garret.kelly@gmail.com>,
        Octavian Purdila <octavian.purdila@intel.com>,
        Andreas <schwab@linux-m68k.org>, Nick Kralevich <nnk@google.com>
Subject: Re: [PATCH V4] Fix pointer cast for 32 bits arch
Message-ID: <20150417082017.GO10964@mwanda>
References: <20150413122911.GW10964@mwanda>
 <1429191546-1398-1-git-send-email-peter.senna@gmail.com>
 <CAMuHMdWmJmQTqgp4JkXO+-H3sy86o8v=XKJuKmQ-G63LDndq9A@mail.gmail.com>
 <20150416170144.GM10964@mwanda>
 <1429203927.2878.238.camel@linux.intel.com>
 <20150417081134.GN10964@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150417081134.GN10964@mwanda>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 832
Lines: 26

Actually, my patch seems like a good idea to me but it's one of those
things that someone should probably test.  Unless someone can test
goldfish on a 32 bit system with 64 bit dma addresses then maybe the
thing to is to write the new function but preserve the current behavior.

static inline void gf_write_dma_addr(dma_addr_t addr, void __iomem *portl,
				     void __iomem *porth)
{
	writel((u32)data, portl);
	/*
	 * This should be CONFIG_ARCH_DMA_ADDR_T_64BIT but someone needs to
	 * test it.
	 */
#ifdef CONFIG_64BIT
	writel(data >> 32, porth);
#endif
}

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/