Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753351AbbDQJCG (ORCPT ); Fri, 17 Apr 2015 05:02:06 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:39204 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752757AbbDQJB6 (ORCPT ); Fri, 17 Apr 2015 05:01:58 -0400 Date: Fri, 17 Apr 2015 10:01:56 +0100 From: Charles Keepax To: Inha Song Cc: lee.jones@linaro.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, cw00.choi@samsung.com, broonie@kernel.org, rf@opensource.wolfsonmicro.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk Subject: Re: [alsa-devel] [PATCH 2/2] mfd: arizona: Update DT binding to support hpdet channel Message-ID: <20150417090156.GD3480@opensource.wolfsonmicro.com> References: <1429259579-16563-1-git-send-email-ideal.song@samsung.com> <1429259579-16563-3-git-send-email-ideal.song@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429259579-16563-3-git-send-email-ideal.song@samsung.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1691 Lines: 40 On Fri, Apr 17, 2015 at 05:32:59PM +0900, Inha Song wrote: > This patch add device tree bindings for the pdata needed to configure > the Accessory Detect Mode select when Headphone detection. > > Signed-off-by: Inha Song > --- > Documentation/devicetree/bindings/mfd/arizona.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt > index 7bd1273..e7cb939 100644 > --- a/Documentation/devicetree/bindings/mfd/arizona.txt > +++ b/Documentation/devicetree/bindings/mfd/arizona.txt > @@ -49,6 +49,10 @@ Optional properties: > input singals. If values less than the number of input signals, elements > that has not been specifed are set to 0 by default. > > + - wlf,hpdet-channel : Headphone detection channel, this filed to be used the > + ACCDET_MODE bits in the ACCESSORY_DETECT_MODE_1 register. The valid values > + are 0 for HPDETL and 1 for HPDETR. Lets remove the references to the register bits this tends to add some confusion to the binding doc review and update to mention the defines I suggested adding in the other patch. Thanks, Charles > + > - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if > they are being externally supplied. As covered in > Documentation/devicetree/bindings/regulator/regulator.txt > -- > 2.0.0.390.gcb682f8 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/