Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 12 Jan 2003 17:29:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 12 Jan 2003 17:29:05 -0500 Received: from mta5.srv.hcvlny.cv.net ([167.206.5.31]:4843 "EHLO mta5.srv.hcvlny.cv.net") by vger.kernel.org with ESMTP id ; Sun, 12 Jan 2003 17:28:55 -0500 Date: Sun, 12 Jan 2003 17:35:44 -0500 From: Rob Wilkens Subject: Re: any chance of 2.6.0-test*? In-reply-to: <20030112221849.GO31238@vitelus.com> To: Aaron Lehmann Cc: Oliver Neukum , Rik van Riel , Matti Aarnio , Linux Kernel Mailing List Reply-to: robw@optonline.net Message-id: <1042410944.1208.168.camel@RobsPC.RobertWilkens.com> Organization: Robert Wilkens MIME-version: 1.0 X-Mailer: Ximian Evolution 1.2.1 Content-type: text/plain Content-transfer-encoding: 7BIT References: <1042407845.3162.131.camel@RobsPC.RobertWilkens.com> <200301122312.41879.oliver@neukum.name> <20030112221849.GO31238@vitelus.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 790 Lines: 23 On Sun, 2003-01-12 at 17:18, Aaron Lehmann wrote: > On Sun, Jan 12, 2003 at 11:12:41PM +0100, Oliver Neukum wrote: > > Yes. Typical error cleanup looks like: > > err_out: > > up(&sem); > > return err; > > > > Releasing a lock in another function is a crime punished by slow death. > > Not to mention that the 'return err;' statement is hard to move to an > inline function meaningfully. Not that hard: You just "return functionname()" where functionname is the name of your inline function that returns the value you want to return. -Rob - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/