Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S966037AbbDQOT5 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Apr 2015 10:19:57 -0400
Received: from mail-wg0-f45.google.com ([74.125.82.45]:35031 "EHLO
	mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933010AbbDQOTy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Apr 2015 10:19:54 -0400
MIME-Version: 1.0
In-Reply-To: <CAH6sp9OK0gLFdv4DX3kMzi4cmYUE0P1mnGrqwWoFd9TYWi5kUw@mail.gmail.com>
References: <1429162034.6726.688.camel@intel.com>
	<CAH6sp9OK0gLFdv4DX3kMzi4cmYUE0P1mnGrqwWoFd9TYWi5kUw@mail.gmail.com>
Date: Fri, 17 Apr 2015 16:19:52 +0200
Message-ID: <CAH6sp9PsQHzT6aos-HHND-G_DGzak-70vH9fXFx8-0Hbdc9j1Q@mail.gmail.com>
Subject: Re: [LKP] [mtd] 6b44d910ae7: WARNING: CPU: 0 PID: 0 at
 kernel/locking/lockdep.c:3547 check_flags+0xae/0x17b()
From: Frans Klaver <fransklaver@gmail.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, LKP ML <lkp@01.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1513
Lines: 38

On Thu, Apr 16, 2015 at 9:34 AM, Frans Klaver <fransklaver@gmail.com> wrote:
> On Thu, Apr 16, 2015 at 7:27 AM, Huang Ying <ying.huang@intel.com> wrote:
>> FYI, we noticed the below changes on
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> commit 6b44d910ae7de5316fcf1fc828ff4a8d48cac5e2 ("mtd: core: set some defaults when dev.parent is set")
>>
>> <panic>
>
> I would then expect that this is actually caused by
> 29b4dacc55b0cb079e5b4be2fbc494e138a7d110 (mtd: nand: docg4: show
> parent device in sysfs), which effectively replaces mtd->owner with
> the automated value. I just noticed that
> module_platform_driver_probe() doesn't set the owner like
> module_platform_driver() does.

Or not. I should probably get more sleep somewhere. omap2 uses
module_platform_driver but still requires .driver.owner to be set to
THIS_MODULE.

>From the looks of it only platform_driver_register() provides the
nicety of automatically filling in the module owner. This still seems
to be an API inconsistency to me.

> I'm happy to
> send in a patch that restores "mtd->owner = THIS_MODULE" with these
> drivers, if that's preferred.

Long story short, I should fix it.

Brian, do you prefer a rework of the series or a patch fixing it?

Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/