Date: Fri, 17 Apr 2015 15:40:47 +0100
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Roy Franz <roy.franz@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
        matt.fleming@intel.com, hpa@zytor.com, mingo@redhat.com,
        x86@kernel.org
Subject: Re: [PATCH] x86/efi: Store upper bits of command line buffer address
 in ext_cmd_line_ptr
Message-ID: <20150417144047.GC3671@codeblueprint.co.uk>
References: <1429140744-25768-1-git-send-email-roy.franz@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1429140744-25768-1-git-send-email-roy.franz@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1282
Lines: 28

On Wed, 15 Apr, at 04:32:24PM, Roy Franz wrote:
> Until now, the EFI stub was only setting the 32 bit cmd_line_ptr in
> the setup_header structure, so on 64 bit platforms this could be truncated.
> This patch adds setting the upper bits of the buffer address in
> ext_cmd_line_ptr.  This case was likely never hit, as the allocation
> for this buffer is done at the lowest available address.  Only
> x86_64 kernels have this problem, as the 1-1 mapping mandated
> by EFI ensures that all memory is 32 bit addressable on 32 bit
> platforms.  The EFI stub does not support mixed mode, so the
> 32 bit kernel on 64 bit firmware case does not need to be handled.
> 
> Signed-off-by: Roy Franz <roy.franz@linaro.org>
> ---
> This is a follow-up to "x86_64/efi: enforce 32 bit address for command line buffer",
> which had the wrong fix to the truncation of address.
> 
>  arch/x86/boot/compressed/eboot.c | 2 ++
>  1 file changed, 2 insertions(+)
 
Looks good to me Roy, thanks applied!

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/