Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932270AbbDQPNH (ORCPT ); Fri, 17 Apr 2015 11:13:07 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:35542 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753581AbbDQPND (ORCPT ); Fri, 17 Apr 2015 11:13:03 -0400 Date: Fri, 17 Apr 2015 11:12:59 -0400 From: Tejun Heo To: Alexey Dobriyan Cc: xiaoming.wang@intel.com, Linux Kernel , Mel Gorman , Andrew Morton Subject: Re: [PATCH] proc: move the adding option Ngid to the end of proc/PID/status Message-ID: <20150417151259.GA16743@htj.duckdns.org> References: <20150417142605.GA1954@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1257 Lines: 32 On Fri, Apr 17, 2015 at 06:05:55PM +0300, Alexey Dobriyan wrote: > Moving Ngid to the end of file minimizes risk of breakage. Hmmm... how so? The only reason for changing the position is because there's this specific breakage. The goal should be working around that specific case while keeping the impact minimum on everyone else. It doesn't matter whether the initial change was good or bad, the kernel w/ the new layout is already out in the wild and it has been out there for a while. How is risking changing offsets on most of the fields on those kernels a good idea? Mimize the changes to work around the specific case. > Correctly written code doesn't care. > Code which hardcodes layout won't notice. Huh? Code which hardcodes layout since 1.5 years ago will definitely notice. > It would be OK argument if gentlemen from Intel send "let's futureproof and > move Ngid because someone might depend on exact position" patch. > > Primum non nocere. ajlkjaeligjlakd lakjeilgjal flekjfa. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/