Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965109AbbDQPex (ORCPT ); Fri, 17 Apr 2015 11:34:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49402 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964948AbbDQPet (ORCPT ); Fri, 17 Apr 2015 11:34:49 -0400 Date: Fri, 17 Apr 2015 17:34:30 +0200 From: Jiri Olsa To: Mathias Krause Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Ingo Molnar , Paul Mackerras , Peter Zijlstra Subject: Re: [PATCH] perf: Ensure symbols for plugins are exported Message-ID: <20150417153430.GF17654@krava> References: <1428854451-28361-1-git-send-email-minipli@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428854451-28361-1-git-send-email-minipli@googlemail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1579 Lines: 30 On Sun, Apr 12, 2015 at 06:00:51PM +0200, Mathias Krause wrote: > When building perf with perl or python support it implicitly gets linked > with the -export-dynamic linker option through the additional linker > flags, namely with -Wl,-E via perl or -Xlinker -export-dynamic via > python. That flag is essential for the traceevent plugin support so we > shouldn't rely on adding it implicitly. > > Ensure perf's exported symbols can be used by dlopen()ed plugins by > unconditionally adding this flag when linking perf. Otherwise plugins > won't be able to access symbols in the perf binary. > > This fixes the following warning / bug when trying to load plugins: > > Warning: could not load plugin '/home/minipli/.traceevent/plugins/plugin_xen.so' > /home/minipli/.traceevent/plugins/plugin_xen.so: undefined symbol: trace_seq_printf > Warning: could not load plugin '/home/minipli/.traceevent/plugins/plugin_function.so' > /home/minipli/.traceevent/plugins/plugin_function.so: undefined symbol: warning > Warning: could not load plugin '/home/minipli/.traceevent/plugins/plugin_sched_switch.so' > /home/minipli/.traceevent/plugins/plugin_sched_switch.so: undefined symbol: pevent_unregister_event_handler > [...] hum, not sure now how -export-dynamic works but should this be rather in traceevent lib then? jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/