Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932088AbbDQRAE (ORCPT ); Fri, 17 Apr 2015 13:00:04 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:34388 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354AbbDQRAB convert rfc822-to-8bit (ORCPT ); Fri, 17 Apr 2015 13:00:01 -0400 MIME-Version: 1.0 In-Reply-To: References: <300602D8-9DB7-4F8D-AC97-B60924554093@holtmann.org> Date: Fri, 17 Apr 2015 18:59:59 +0200 Message-ID: Subject: Re: [V4.1] Regression: Bluetooth mouse not working. From: =?UTF-8?Q?J=C3=B6rg_Otte?= To: Marcel Holtmann Cc: Linus Torvalds , "Gustavo F. Padovan" , Johan Hedberg , "bluez mailin list (linux-bluetooth@vger.kernel.org)" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1928 Lines: 55 2015-04-17 18:55 GMT+02:00 Jörg Otte : > 2015-04-17 18:51 GMT+02:00 Marcel Holtmann : >> Hi Joerg, >> >>>>> On Fri, Apr 17, 2015 at 5:36 AM, Jörg Otte wrote: >>>>>> The BT mouse is "death" in v4.1. >>>>>> The BT mouse has been working in 4.0 and previous kernels, so this >>>>>> is a regression. >>>>> >>>>> Any chance of bisecting it? >>>>> >>>>> Linus >>>> I will try that. >>>> >>>> Thanks, Jörg >>> >>> I first tried to bisect over all. But than I got an unbootable kernel. >>> Then I did a bisect over net/bluetooth and I get the following fist bad >>> commit: >>> >>> 5f5da99f1da5b01c7c45473a500c7dbb77a00958 is the first bad commit >>> commit 5f5da99f1da5b01c7c45473a500c7dbb77a00958 >>> Author: Marcel Holtmann >>> Date: Wed Apr 1 13:51:53 2015 -0700 >>> >>> Bluetooth: Restrict HIDP flags to only valid ones >>> >>> The HIDP flags should be clearly restricted to valid ones. So this puts >>> extra checks in place to ensure this. >>> >>> Signed-off-by: Marcel Holtmann >>> Signed-off-by: Johan Hedberg >>> >>> :040000 040000 b51ac3634c9d44f4d9df0e7f548b524954b99c76 >>> 63bfb47283609849f1b3b8f05fe61743ccddfee6 M net >> >> thanks for bi-secting this. I looked at our existing userspace and restricted it to the flags that are currently in use. However it seems that I made a mistake. What version of BlueZ userspace are you using (bluetoothd --version). >> >> Regards >> >> Marcel >> > bluetoothd --version > 4.98 > > Thanks, Jörg Just reverted that commit. It fixed the problem for me. Thanks, Jörg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/