Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754866AbbDQRTQ (ORCPT ); Fri, 17 Apr 2015 13:19:16 -0400 Received: from senator.holtmann.net ([87.106.208.187]:43850 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753624AbbDQRTO convert rfc822-to-8bit (ORCPT ); Fri, 17 Apr 2015 13:19:14 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: [V4.1] Regression: Bluetooth mouse not working. From: Marcel Holtmann In-Reply-To: <38429B86-0E46-4C6A-9954-3260D864B10C@holtmann.org> Date: Fri, 17 Apr 2015 10:19:06 -0700 Cc: Linus Torvalds , "Gustavo F. Padovan" , Johan Hedberg , "bluez mailin list (linux-bluetooth@vger.kernel.org)" , Linux Kernel Mailing List Content-Transfer-Encoding: 8BIT Message-Id: References: <300602D8-9DB7-4F8D-AC97-B60924554093@holtmann.org> <38429B86-0E46-4C6A-9954-3260D864B10C@holtmann.org> To: =?utf-8?Q?J=C3=B6rg_Otte?= X-Mailer: Apple Mail (2.2098) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2039 Lines: 53 Hi Joerg, >>>>>> On Fri, Apr 17, 2015 at 5:36 AM, Jörg Otte wrote: >>>>>>> The BT mouse is "death" in v4.1. >>>>>>> The BT mouse has been working in 4.0 and previous kernels, so this >>>>>>> is a regression. >>>>>> >>>>>> Any chance of bisecting it? >>>>>> >>>>>> Linus >>>>> I will try that. >>>>> >>>>> Thanks, Jörg >>>> >>>> I first tried to bisect over all. But than I got an unbootable kernel. >>>> Then I did a bisect over net/bluetooth and I get the following fist bad >>>> commit: >>>> >>>> 5f5da99f1da5b01c7c45473a500c7dbb77a00958 is the first bad commit >>>> commit 5f5da99f1da5b01c7c45473a500c7dbb77a00958 >>>> Author: Marcel Holtmann >>>> Date: Wed Apr 1 13:51:53 2015 -0700 >>>> >>>> Bluetooth: Restrict HIDP flags to only valid ones >>>> >>>> The HIDP flags should be clearly restricted to valid ones. So this puts >>>> extra checks in place to ensure this. >>>> >>>> Signed-off-by: Marcel Holtmann >>>> Signed-off-by: Johan Hedberg >>>> >>>> :040000 040000 b51ac3634c9d44f4d9df0e7f548b524954b99c76 >>>> 63bfb47283609849f1b3b8f05fe61743ccddfee6 M net >>> >>> thanks for bi-secting this. I looked at our existing userspace and restricted it to the flags that are currently in use. However it seems that I made a mistake. What version of BlueZ userspace are you using (bluetoothd --version). >>> >>> >> bluetoothd --version >> 4.98 > > okay. I only looked at BlueZ 5.x and that might have been my mistake. Let me check this and fix this properly. I think that I know what I screwed up here. I sent you a patch to fix this. Can you please test it and report back. If that fixes it for you, then I will send it to Linus for inclusion. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/