Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933922AbbDQRls (ORCPT ); Fri, 17 Apr 2015 13:41:48 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:58710 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753485AbbDQRlq (ORCPT ); Fri, 17 Apr 2015 13:41:46 -0400 Date: Fri, 17 Apr 2015 19:41:31 +0200 From: Peter Zijlstra To: Richard Guy Briggs Cc: containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-audit@redhat.com, sgrubb@redhat.com, eparis@parisplace.org, pmoore@redhat.com, arozansk@redhat.com, ebiederm@xmission.com, serge@hallyn.com, zohar@linux.vnet.ibm.com, linux-api@vger.kernel.org, mingo@redhat.com Subject: Re: [PATCH V6 07/10] sched: add a macro to ref all CLONE_NEW* flags Message-ID: <20150417174131.GL23123@twins.programming.kicks-ass.net> References: <20150417081843.GE23123@twins.programming.kicks-ass.net> <20150417154250.GA26233@madcap2.tricolour.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150417154250.GA26233@madcap2.tricolour.ca> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1513 Lines: 34 On Fri, Apr 17, 2015 at 11:42:50AM -0400, Richard Guy Briggs wrote: > On 15/04/17, Peter Zijlstra wrote: > > On Fri, Apr 17, 2015 at 03:35:54AM -0400, Richard Guy Briggs wrote: > > > Added the macro CLONE_NEW_MASK_ALL to refer to all CLONE_NEW* flags. > > > > A wee bit about why might be nice.. > > It makes the following patch much cleaner to read: > [PATCH V6 08/10] fork: audit on creation of new namespace(s) > https://lkml.org/lkml/2015/4/17/50 > > I was hoping it might also make a lot of other code cleaner, but most of > the other places where multiple CLONE_NEW* flags are used, not all six > are used together, but only 5 are used. Ok, so it is helpful in 1 of 3: > > It would actually be useful in check_unshare_flags(): > https://github.com/torvalds/linux/blob/v3.17/kernel/fork.c#L1791 > > but not in copy_namespaces() or unshare_nsproxy_namespaces(): > https://github.com/torvalds/linux/blob/v3.17/kernel/nsproxy.c#L130 > https://github.com/torvalds/linux/blob/v3.17/kernel/nsproxy.c#L183 > Right, so no objections from me on this, its just that I only saw this one patch in isolation without context and the changelog failed on rationale. Does it perchance make sense to fold this patch into the next patch that actually makes use of it? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/