Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753902AbbDQSPL (ORCPT ); Fri, 17 Apr 2015 14:15:11 -0400 Received: from mga14.intel.com ([192.55.52.115]:8480 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbbDQSPH (ORCPT ); Fri, 17 Apr 2015 14:15:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,596,1422950400"; d="scan'208";a="715378342" Date: Fri, 17 Apr 2015 23:39:59 +0530 From: Vinod Koul To: Niklas Cassel Cc: ludovic.desroches@atmel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Niklas Cassel Subject: Re: [PATCH] dmaengine: at_xdmac: unlock spin lock before return Message-ID: <20150417180959.GI30624@intel.com> References: <1428417765-16910-1-git-send-email-niklass@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428417765-16910-1-git-send-email-niklass@axis.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 34 On Tue, Apr 07, 2015 at 04:42:45PM +0200, Niklas Cassel wrote: > Signed-off-by: Niklas Cassel > --- > drivers/dma/at_xdmac.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index d9891d3..933e4b3 100644 > --- a/drivers/dma/at_xdmac.c > +++ b/drivers/dma/at_xdmac.c > @@ -1154,8 +1154,10 @@ static int at_xdmac_device_resume(struct dma_chan *chan) > dev_dbg(chan2dev(chan), "%s\n", __func__); > > spin_lock_bh(&atchan->lock); > - if (!at_xdmac_chan_is_paused(atchan)) > + if (!at_xdmac_chan_is_paused(atchan)) { > + spin_unlock_bh(&atchan->lock); > return 0; > + } > > at_xdmac_write(atxdmac, AT_XDMAC_GRWR, atchan->mask); > clear_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status); > -- > 2.1.4 > Applied now -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/