Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932997AbbDQTWG (ORCPT ); Fri, 17 Apr 2015 15:22:06 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46256 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932834AbbDQTWC (ORCPT ); Fri, 17 Apr 2015 15:22:02 -0400 Date: Fri, 17 Apr 2015 15:22:00 -0400 (EDT) Message-Id: <20150417.152200.405809009304639029.davem@davemloft.net> To: dvlasenk@redhat.com Cc: ebiederm@xmission.com, jengelh@medozas.de, jpirko@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] netns: remove BUG_ONs from net_generic() From: David Miller In-Reply-To: <1429290390-5600-1-git-send-email-dvlasenk@redhat.com> References: <1429290390-5600-1-git-send-email-dvlasenk@redhat.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 17 Apr 2015 12:22:02 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 24 From: Denys Vlasenko Date: Fri, 17 Apr 2015 19:06:30 +0200 > This inline has ~500 callsites. > > On 04/14/2015 08:37 PM, David Miller wrote: >> That BUG_ON() was added 7 years ago, and I don't remember it ever >> triggering or helping us diagnose something, so just remove it and >> keep the function inlined. > > On x86 allyesconfig build: > > text data bss dec hex filename > 82447071 22255384 20627456 125329911 77861f7 vmlinux4 > 82441375 22255384 20627456 125324215 7784bb7 vmlinux5prime > > Signed-off-by: Denys Vlasenko Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/