Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932133AbbDQTkO (ORCPT ); Fri, 17 Apr 2015 15:40:14 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:36731 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbbDQTkL (ORCPT ); Fri, 17 Apr 2015 15:40:11 -0400 Date: Fri, 17 Apr 2015 20:39:52 +0100 From: Russell King - ARM Linux To: Michael Welling Cc: Sebastian Hesselbarth , Tero Kristo , Mike Turquette , Stephen Boyd , Linux OMAP Mailing List , "linux-kernel@vger.kernel.org" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree , "linux-arm-kernel@lists.infradead.org" , Tony Lindgren , Greg Kroah-Hartman , Daniel Mack Subject: Re: AM335x OMAP2 common clock external fixed-clock registration Message-ID: <20150417193952.GV4027@n2100.arm.linux.org.uk> References: <20150415205136.GA3399@deathray> <552F3B60.8050703@ti.com> <20150416161756.GA27590@deathray> <55301D7F.30708@gmail.com> <20150416220918.GA6057@deathray> <55304486.5020404@gmail.com> <20150417020048.GA27174@deathray> <5530CE63.9070508@gmail.com> <20150417101833.GU4027@n2100.arm.linux.org.uk> <20150417190623.GA24506@deathray> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150417190623.GA24506@deathray> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1729 Lines: 39 On Fri, Apr 17, 2015 at 02:06:23PM -0500, Michael Welling wrote: > On Fri, Apr 17, 2015 at 11:18:33AM +0100, Russell King - ARM Linux wrote: > > On Fri, Apr 17, 2015 at 11:12:03AM +0200, Sebastian Hesselbarth wrote: > > > On 17.04.2015 04:00, Michael Welling wrote: > > > >On Fri, Apr 17, 2015 at 01:23:50AM +0200, Sebastian Hesselbarth wrote: > > > >>On 17.04.2015 00:09, Michael Welling wrote: > > > >>>On Thu, Apr 16, 2015 at 10:37:19PM +0200, Sebastian Hesselbarth wrote: > > > >>>>On 16.04.2015 18:17, Michael Welling wrote: > > > [...] > > > >>>What would be the proper error path? > > > >>>What cleanup is required? > > > >> > > > >>A proper error path would be to release any claimed resource > > > >>on any error. If you look at the code, the only resources that > > > >>need to be released are the two clocks in question. > > > > > > > >So for every error return in the probe function and in the of si5351_dt_parse > > > >it needs to clk_put first right? > > > > > > Not quite. The driver should clk_put() every clock that it called a > > > [of_]clk_get() for. The thing is that clocks can be passed by > > > platform_data and we never claim them. > > > > I've always said clocks (as in struct clk) should never be passed through > > platform data. > > > > What is the alternative for systems that still use the old platform files? clkdev, which has pre-existed DT. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/