Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754239AbbDQTqp (ORCPT ); Fri, 17 Apr 2015 15:46:45 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:40165 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076AbbDQTqm (ORCPT ); Fri, 17 Apr 2015 15:46:42 -0400 Date: Fri, 17 Apr 2015 14:45:20 -0500 From: Felipe Balbi To: Felipe Balbi CC: David Cohen , , , , Subject: Re: [PATCH] usb: dwc3: gadget: call gadget driver's ->suspend/->resume Message-ID: <20150417194520.GN2823@saruman.tx.rr.com> Reply-To: References: <1429296116-3062-1-git-send-email-david.a.cohen@linux.intel.com> <20150417194327.GM2823@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bEjdSXxHv0Az5++U" Content-Disposition: inline In-Reply-To: <20150417194327.GM2823@saruman.tx.rr.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3018 Lines: 89 --bEjdSXxHv0Az5++U Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 17, 2015 at 02:43:27PM -0500, Felipe Balbi wrote: > On Fri, Apr 17, 2015 at 11:41:56AM -0700, David Cohen wrote: > > From: Felipe Balbi >=20 > missing the required: >=20 > [ Upstream commit bc5ba2e0b829c9397f96df1191c7d2319ebc36d9 ] >=20 > >=20 > > When going into bus suspend/resume we _must_ > > call gadget driver's ->suspend/->resume callbacks > > accordingly. This patch implements that very feature > > which has been missing forever. > >=20 > > Cc: # 3.14 > > Signed-off-by: Felipe Balbi > > Signed-off-by: David Cohen > > --- > >=20 > > Hi, > >=20 > > This patch was introduced on v3.15. > > But the issue it fixes already existed on v3.14 and v3.14 is a long term > > support version. >=20 > Can you show me a log of this breaking anywhere ? Why do you consider > this a bug fix ? What sort of drawbacks did you notice ? >=20 > > I propose to backport it over there as well. > >=20 > > BR, David > > --- > >=20 > > drivers/usb/dwc3/gadget.c | 35 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 35 insertions(+) > >=20 > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > > index 8f6738d46b14..1bb752736c32 100644 > > --- a/drivers/usb/dwc3/gadget.c > > +++ b/drivers/usb/dwc3/gadget.c > > @@ -2012,6 +2012,24 @@ static void dwc3_disconnect_gadget(struct dwc3 *= dwc) > > } > > } > > =20 > > +static void dwc3_suspend_gadget(struct dwc3 *dwc) > > +{ > > + if (dwc->gadget_driver && dwc->gadget_driver->disconnect) { >=20 > you also need Dan Carperter's commit which fixes this cut & paste error. That's Carpenter, sorry. --=20 balbi --bEjdSXxHv0Az5++U Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVMWLQAAoJEIaOsuA1yqREtGQP/25xgfF0UUjG88mB76ZzgiZK bd1nLQnnDWSKoe9ZnL61oAFoZ9EIDbvO0OC9lq8tKtjqQLoOH+8bqA/5XxPd+XTO 3eLu86cE9WO6zZbcYdCzpS9sfp5tUQlSuNJcjwuV/cH/Q8IHzgUG3q8w2trnbH2z 2MPls3xyhDk3pduVmjtZPqYAMJDJr5zs8xEm2T1yvBXFv1IAMaEeAKg9p9Q92BaG B7fNHJHyJcIMU+VehhTAAgRyVJOlkwufHsgacxHT0wYSGSY4dVypa5I5vV4z25w5 Ed1YGVkgq+6bFEi3nTD3JQk8/ElCYs2e0gUoX7HmwstmHQFKJBEqOHtqYD1u7xhK /rdxkSdPdSyHrCNiMLxKQoZAh1DTAkqRCURY7JpnENERWlH1YiP/qX3NGI8HiXtK xnuSgEHHiXwOhmwEaSXamw+iipaf+VOYSixueKVhy0GK76qLkSsVp98J6nDApupP wFnpakhR/EPc1dIZrgVSqLJt3AzQubY1ujTM3Gp97XFT/x8swYQOXCURSnc25LCG JeFIzqmM31IEgea2DEZrhHMuvK3HHaK2vwdnMiEPVVGDb7LXSh4Je2rF34meB6dY YcaBpWZuWMRPBbu7smczd8KTFci+m4oyYIQZhx0KHgqP28lAli5wtxnI3F+8Dvo4 QcxcTbR+iTs5ZQIILsAo =ktsa -----END PGP SIGNATURE----- --bEjdSXxHv0Az5++U-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/