Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753251AbbDQVQ5 (ORCPT ); Fri, 17 Apr 2015 17:16:57 -0400 Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]:48724 "EHLO lb3-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbbDQVQz (ORCPT ); Fri, 17 Apr 2015 17:16:55 -0400 Message-ID: <1429305405.16771.114.camel@x220> Subject: Re: [PATCH 1/5] clocksource: st_lpc: Add LPC timer as a clocksource. From: Paul Bolle To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, daniel.lezcano@linaro.org, tglx@linutronix.de, lee.jones@linaro.org, devicetree@vger.kernel.org, Ajit Pal Singh Date: Fri, 17 Apr 2015 23:16:45 +0200 In-Reply-To: <1429267823-8879-2-git-send-email-peter.griffin@linaro.org> References: <1429267823-8879-1-git-send-email-peter.griffin@linaro.org> <1429267823-8879-2-git-send-email-peter.griffin@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1552 Lines: 62 On Fri, 2015-04-17 at 11:50 +0100, Peter Griffin wrote: > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > +config CLKSRC_ST_LPC_CLOCK > + bool > + depends on ARCH_STI > + select CLKSRC_OF if OF > + help > + Enable this option to use the Low Power controller timer > + as clock source. > + > +config CLKSRC_ST_LPC_TIMER_SCHED_CLOCK > + bool > + depends on ST_LPC_CLOCK It looks like you meant depends on CLKSRC_ST_LPC_CLOCK > + default y > + help > + Use Low Power controller timer clock source as sched_clock > --- a/drivers/clocksource/Makefile > +++ b/drivers/clocksource/Makefile > +obj-$(CONFIG_CLKSRC_ST_LPC_CLOCK) += st_lpc.o > --- /dev/null > +++ b/drivers/clocksource/st_lpc.c > +#ifdef CONFIG_CLKSRC_LPC_TIMER_SCHED_CLOCK #ifdef CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK here? > +static u64 notrace st_lpc_sched_clock_read(void) > +{ > + return st_lpc_counter_read(); > +} > +#endif > +#ifdef CONFIG_CLKSRC_LPC_TIMER_SCHED_CLOCK Again, #ifdef CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK here? > + sched_clock_register(st_lpc_sched_clock_read, 64, rate); > +#endif Assuming the above suggestions are correct: checkkconfigsymbols.py, as shipped in linux-next, helps detect stuff like this. See scripts/checkkconfigsymbols.py --help. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/