Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753808AbbDQWPG (ORCPT ); Fri, 17 Apr 2015 18:15:06 -0400 Received: from mail-vn0-f53.google.com ([209.85.216.53]:38939 "EHLO mail-vn0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751703AbbDQWPD (ORCPT ); Fri, 17 Apr 2015 18:15:03 -0400 MIME-Version: 1.0 In-Reply-To: References: <1429308109-5133-1-git-send-email-tyler.baker@linaro.org> Date: Fri, 17 Apr 2015 15:15:02 -0700 Message-ID: Subject: Re: [PATCH v2 6/8] selftest/x86: have no dependency on all when cross building From: Tyler Baker To: Andy Lutomirski Cc: Shuah Khan , Kevin Hilman , John Stultz , Darren Hart , David Herrmann , Michael Ellerman , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1669 Lines: 68 On 17 April 2015 at 15:08, Andy Lutomirski wrote: > On Fri, Apr 17, 2015 at 3:01 PM, Tyler Baker wrote: >> If the CROSS_COMPILE is set have no dependency on all. > > You mean "remove all's dependency on all_32 and all_64", I think. Yes I'll clean this up. > >> >> Cc: Andy Lutomirski >> Signed-off-by: Tyler Baker >> --- >> tools/testing/selftests/x86/Makefile | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile >> index 57090ad..9962e10 100644 >> --- a/tools/testing/selftests/x86/Makefile >> +++ b/tools/testing/selftests/x86/Makefile >> @@ -9,13 +9,17 @@ CFLAGS := -O2 -g -std=gnu99 -pthread -Wall >> >> UNAME_M := $(shell uname -m) > > I think you should add > > all: > > above. Otherwise, with CROSS_COMPILE set, the default rule won't be > 'all' any more. Ack. Good suggestion, thanks. > > -Andy > >> >> +ifeq ($(CROSS_COMPILE),) >> # Always build 32-bit tests >> all: all_32 >> - >> # If we're on a 64-bit host, build 64-bit tests as well >> ifeq ($(UNAME_M),x86_64) >> all: all_32 all_64 >> endif >> +else >> +# No dependency on all when cross building >> +all: >> +endif >> >> all_32: check_build32 $(BINARIES_32) >> >> -- >> 2.1.4 >> > > > > -- > Andy Lutomirski > AMA Capital Management, LLC Tyler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/