Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754017AbbDQWeT (ORCPT ); Fri, 17 Apr 2015 18:34:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57347 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbbDQWeQ (ORCPT ); Fri, 17 Apr 2015 18:34:16 -0400 Date: Sat, 18 Apr 2015 08:34:02 +1000 From: NeilBrown To: Pavel Machek Cc: NeilBrown , Kishon Vijay Abraham I , Tony Lindgren , GTA04 owners , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] phy: twl4030-usb: add ABI documentation Message-ID: <20150418083402.5b626011@notabene.brown> In-Reply-To: <20150417221436.GA11429@amd> References: <20150416075945.23307.24424.stgit@notabene.brown> <20150416080304.23307.7824.stgit@notabene.brown> <20150417221436.GA11429@amd> X-Mailer: Claws Mail 3.10.1-162-g4d0ed6 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/S7jxHtlN.TgXiPXo609GpxP"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2681 Lines: 75 --Sig_/S7jxHtlN.TgXiPXo609GpxP Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 18 Apr 2015 00:14:36 +0200 Pavel Machek wrote: > On Thu 2015-04-16 18:03:04, NeilBrown wrote: > > From: NeilBrown > >=20 > > This driver device one local attribute: vbus. > > Describe that in Documentation/ABI/testing/sysfs-platform/twl4030-usb. > >=20 > > Signed-off-by: NeilBrown > > --- > > .../ABI/testing/sysfs-platform-twl4030-usb | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > create mode 100644 Documentation/ABI/testing/sysfs-platform-twl4030-usb > >=20 > > diff --git a/Documentation/ABI/testing/sysfs-platform-twl4030-usb b/Doc= umentation/ABI/testing/sysfs-platform-twl4030-usb > > new file mode 100644 > > index 000000000000..512c51be64ae > > --- /dev/null > > +++ b/Documentation/ABI/testing/sysfs-platform-twl4030-usb > > @@ -0,0 +1,8 @@ > > +What: /sys/bus/platform/devices/*twl4030-usb/vbus > > +Description: > > + Read-only status reporting if VBUS (approx 5V) > > + is being supplied by the USB bus. > > + > > + Possible values: "on", "off". >=20 > Would bit be better to have values "0" and "1"? Kernel usually does > that for booleans... 1/ The code already uses "on" and "off", so changing would be an ABI breakage. 2/ No it doesn't. For modules params, the kernel uses "Y" and "N" git grep '? "on" : "off"' | wc find 172 matches. NeilBrown --Sig_/S7jxHtlN.TgXiPXo609GpxP Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIVAwUBVTGKWjnsnt1WYoG5AQJkdA//VMLH28j3P7pE6U9O81VHZtFJjM7mrDcL X72CbtGa7QqyVbgjUtXnRXDFYa7Ds9i8DBdQ5ZaNn8NJk0uLfT62nRHQ0PSlT7Do 32ffVIYzDbaW/iVJ+5tU2EUfWufL8Tjn+Oyy09tA2NqIh9LUgNhDtaSIesB37N2Q 9l/RBE8ptTGyzhIjmFEG+FmbWzzjz3zog89cZUlJPalui7/0iWM9P+PLmVG/vO9E MM5S0jbA6UWwe5X6oVJIp/S5SUMbdIbwtwRq2mNv/MA59G+/6+ZbUFlbiD53sz0S BPlIQSVNBCSLNDNn9yXpxx8SO0naX89yLSw0aN8ump8tCwpjgg8pqdEKTaoUNz+R YurrTrhccaegcoGFwBj/yznaWwyG4nMWH4sGDn3FPXcQFROUOf5QEkA4AzG/hgNU Z/URS0pWuG9w0kHqQPpOH1+lKIbd+I8ZmzZvnVz1CM00ip5OU6cvJUw2xrsf5/qr 77SkIADQGQMPFouJK6erZN+WrhXe36ZuB3M+H0OEoNhONpF4i3pTqXJWBGnZo04M Sj74MDqv+IeU6A7A88KB1820igrqbo/d1YdRnr2Cc5BP52Oym0g4XqIF03U1cbVc ddNSPY6tGkABuuoIH0A712OGFmSA+8ViNfM74yh/fYcQEh2YJgivGjHhTSzW8YS9 MKFZf2xPAEg= =rBbX -----END PGP SIGNATURE----- --Sig_/S7jxHtlN.TgXiPXo609GpxP-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/