Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932334AbbDQWfV (ORCPT ); Fri, 17 Apr 2015 18:35:21 -0400 Received: from mail-vn0-f51.google.com ([209.85.216.51]:39087 "EHLO mail-vn0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753210AbbDQWfT (ORCPT ); Fri, 17 Apr 2015 18:35:19 -0400 MIME-Version: 1.0 In-Reply-To: References: <1429308126-5591-1-git-send-email-tyler.baker@linaro.org> Date: Fri, 17 Apr 2015 15:35:19 -0700 Message-ID: Subject: Re: [PATCH v2 7/8] selftest/x86: install tests From: Tyler Baker To: Andy Lutomirski Cc: Shuah Khan , Kevin Hilman , John Stultz , Darren Hart , David Herrmann , Michael Ellerman , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2306 Lines: 78 On 17 April 2015 at 15:28, Andy Lutomirski wrote: > On Fri, Apr 17, 2015 at 3:02 PM, Tyler Baker wrote: >> Include lib.mk and set TEST_PROGS where appropriate. Skip the install and test >> case when CROSS_COMPILE is not set. >> >> Cc: Andy Lutomirski >> Signed-off-by: Tyler Baker >> --- >> tools/testing/selftests/x86/Makefile | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile >> index 9962e10..622717e 100644 >> --- a/tools/testing/selftests/x86/Makefile >> +++ b/tools/testing/selftests/x86/Makefile >> @@ -12,19 +12,28 @@ UNAME_M := $(shell uname -m) >> ifeq ($(CROSS_COMPILE),) >> # Always build 32-bit tests >> all: all_32 >> +# Install 32-bit tests >> +TEST_PROGS += $(BINARIES_32) run_x86_tests.sh >> # If we're on a 64-bit host, build 64-bit tests as well >> ifeq ($(UNAME_M),x86_64) >> all: all_32 all_64 >> +# Install 64-bit tests >> +TEST_PROGS += $(BINARIES_64) >> endif >> else >> # No dependency on all when cross building >> all: >> +# Skip install and test case when not built >> +override INSTALL_RULE := >> +override EMIT_TESTS := echo "echo \"selftests: run_x86_tests.sh [SKIP]\"" > > I may just be confused, but why is an emply TEST_PROGS insufficient? This is a good question. The default install in lib.mk rule blindly calls 'install -t ' which fails the install as it is not enough arguments passed. Perhaps we fix this behavior in lib.mk. > > --Andy > >> endif >> >> all_32: check_build32 $(BINARIES_32) >> >> all_64: $(BINARIES_64) >> >> +include ../lib.mk >> + >> clean: >> $(RM) $(BINARIES_32) $(BINARIES_64) >> >> -- >> 2.1.4 >> > > > > -- > Andy Lutomirski > AMA Capital Management, LLC -- Tyler Baker Tech Lead, LAVA Linaro.org | Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/