Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752492AbbDRArJ (ORCPT ); Fri, 17 Apr 2015 20:47:09 -0400 Received: from one.firstfloor.org ([193.170.194.197]:36261 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbbDRArI (ORCPT ); Fri, 17 Apr 2015 20:47:08 -0400 Date: Sat, 18 Apr 2015 02:47:06 +0200 From: Andi Kleen To: Mark Rutland Cc: Andi Kleen , Kan Liang , "acme@kernel.org" , "a.p.zijlstra@chello.nl" , "eranian@google.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2 1/6] perf,core: allow invalid context events to be part of sw/hw groups Message-ID: <20150418004705.GA2366@two.firstfloor.org> References: <1429084576-1078-1-git-send-email-kan.liang@intel.com> <20150416163140.GA19775@leverpostej> <20150416212342.GW2366@two.firstfloor.org> <20150417094746.GA21655@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150417094746.GA21655@leverpostej> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 33 > ... which would give you arbitrary skew, because one counter is > free-running and the other is not (when scheduling a context in or out we stop > the PMU) Everyone just reads the counter and subtracts it from the last value they've seen. That's the same how any other shared free running counter work, such as the standard timer. The only thing that perf needs to enforce is that the counters are running with the same event. It also wouldn't work for sampling, but the uncore doesn't do sampling anyways. > From my PoV that violates group semantics, because now the events aren't > always counting at the same time (which would be the reason I grouped > them in the first place). You never use the absolute value, just differences. The differences effectively count only when the group runs. > However, it is the case that you cannot offer group semantics. I don't think that's true. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/