Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753175AbbDRMFU (ORCPT ); Sat, 18 Apr 2015 08:05:20 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:45993 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752952AbbDRMFP (ORCPT ); Sat, 18 Apr 2015 08:05:15 -0400 Date: Sat, 18 Apr 2015 08:05:10 -0400 From: Sowmini Varadhan To: Guenter Roeck Cc: linux-kernel@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org Subject: Re: sparc64: Build failure due to commit f1600e549b94 (sparc: Make sparc64 use scalable lib/iommu-common.c functions) Message-ID: <20150418120510.GB1587@oracle.com> References: <20150418054705.GA10746@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150418054705.GA10746@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1356 Lines: 37 On (04/17/15 22:47), Guenter Roeck wrote: > The problem is caused by commit f1600e549b94 ("sparc: Make sparc64 > use scalable lib/iommu-common.c functions"), which introduces > > static DEFINE_PER_CPU(unsigned int, iommu_pool_hash); I have to confess that I'm a little confused about what happened here.. The specific patch (2/3) above should have come from this submission http://www.spinics.net/lists/sparclinux/msg13786.html aka http://patchwork.ozlabs.org/patch/459803/ This does not add any additional defines for iommu_pool_hash. It also does not have any references to fields like page_table_map_base: instead, these were switched over to things like: - *dma_addrp = (iommu->page_table_map_base + + *dma_addrp = (iommu->tbl.table_map_base + ((iopte - iommu->page_table) << IO_PAGE_SHIFT)); But when I clone git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc.git and do a git show of the commit-id above, I see deltas that dont make sense (they seem to be from a patchset from somewhere in the middle of the review chain from the thread). What am I missing? --Sowmini -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/