Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966AbbDRNeY (ORCPT ); Sat, 18 Apr 2015 09:34:24 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:36005 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbbDRNeW (ORCPT ); Sat, 18 Apr 2015 09:34:22 -0400 Date: Sat, 18 Apr 2015 15:34:08 +0200 From: Peter Senna Tschudin To: Alan Cox Cc: Dan Carpenter , driverdevel , Greg Kroah-Hartman , Jun Tian , "linux-kernel@vger.kernel.org" , Geert Uytterhoeven , Garret Kelly , Octavian Purdila , Andreas , Nick Kralevich Subject: Re: [PATCH V4] Fix pointer cast for 32 bits arch Message-ID: <20150418133408.GA442@toshiba-peter.localdomain> References: <20150413122911.GW10964@mwanda> <1429191546-1398-1-git-send-email-peter.senna@gmail.com> <20150416170144.GM10964@mwanda> <1429203927.2878.238.camel@linux.intel.com> <20150417081134.GN10964@mwanda> <20150417082017.GO10964@mwanda> <1429277509.2878.258.camel@linux.intel.com> <20150417135927.GP10964@mwanda> <1429279819.2878.266.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429279819.2878.266.camel@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1599 Lines: 41 On Fri, Apr 17, 2015 at 4:10 PM, Alan Cox wrote: > On Fri, 2015-04-17 at 16:59 +0300, Dan Carpenter wrote: >> On Fri, Apr 17, 2015 at 02:31:49PM +0100, Alan Cox wrote: >> > On Fri, 2015-04-17 at 11:20 +0300, Dan Carpenter wrote: >> > > Actually, my patch seems like a good idea to me but it's one of those >> > > things that someone should probably test. Unless someone can test >> > > goldfish on a 32 bit system with 64 bit dma addresses >> > >> > No such "system" exists. >> >> I don't understand. We definitely can have 64bit dma addresses on >> x86_32. > > > Yes but no actual Goldfish environment is built that way Isn't this a simpler fix? diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c index 213877a..053ac11 100644 --- a/drivers/staging/goldfish/goldfish_nand.c +++ b/drivers/staging/goldfish/goldfish_nand.c @@ -87,7 +87,7 @@ static u32 goldfish_nand_cmd(struct mtd_info *mtd, enum nand_cmd cmd, writel((u32)(addr >> 32), base + NAND_ADDR_HIGH); writel((u32)addr, base + NAND_ADDR_LOW); writel(len, base + NAND_TRANSFER_SIZE); - gf_write64((u64)ptr, base + NAND_DATA, base + NAND_DATA_HIGH); + gf_write64((unsigned long)ptr, base + NAND_DATA, base + NAND_DATA_HIGH); writel(cmd, base + NAND_COMMAND); rv = readl(base + NAND_RESULT); } -- Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/