Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753449AbbDROAa (ORCPT ); Sat, 18 Apr 2015 10:00:30 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:30314 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591AbbDROA1 (ORCPT ); Sat, 18 Apr 2015 10:00:27 -0400 Date: Sat, 18 Apr 2015 16:59:55 +0300 From: Dan Carpenter To: Peter Senna Tschudin Cc: Alan Cox , driverdevel , Greg Kroah-Hartman , Jun Tian , "linux-kernel@vger.kernel.org" , Geert Uytterhoeven , Garret Kelly , Octavian Purdila , Andreas , Nick Kralevich Subject: Re: [PATCH V4] Fix pointer cast for 32 bits arch Message-ID: <20150418135955.GQ10964@mwanda> References: <1429191546-1398-1-git-send-email-peter.senna@gmail.com> <20150416170144.GM10964@mwanda> <1429203927.2878.238.camel@linux.intel.com> <20150417081134.GN10964@mwanda> <20150417082017.GO10964@mwanda> <1429277509.2878.258.camel@linux.intel.com> <20150417135927.GP10964@mwanda> <1429279819.2878.266.camel@linux.intel.com> <20150418133408.GA442@toshiba-peter.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150418133408.GA442@toshiba-peter.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1208 Lines: 32 On Sat, Apr 18, 2015 at 03:34:08PM +0200, Peter Senna Tschudin wrote: > > > On Fri, Apr 17, 2015 at 4:10 PM, Alan Cox wrote: > > On Fri, 2015-04-17 at 16:59 +0300, Dan Carpenter wrote: > >> On Fri, Apr 17, 2015 at 02:31:49PM +0100, Alan Cox wrote: > >> > On Fri, 2015-04-17 at 11:20 +0300, Dan Carpenter wrote: > >> > > Actually, my patch seems like a good idea to me but it's one of those > >> > > things that someone should probably test. Unless someone can test > >> > > goldfish on a 32 bit system with 64 bit dma addresses > >> > > >> > No such "system" exists. > >> > >> I don't understand. We definitely can have 64bit dma addresses on > >> x86_32. > > > > > > Yes but no actual Goldfish environment is built that way > Isn't this a simpler fix? I still think my fix is cleanest even though dma_addr_t and size_t are always the same. It just means that we can commit it without worrying about testing. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/