Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754030AbbDRQcN (ORCPT ); Sat, 18 Apr 2015 12:32:13 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]:38588 "EHLO smtp1-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753859AbbDRQcL (ORCPT ); Sat, 18 Apr 2015 12:32:11 -0400 X-Greylist: delayed 1105 seconds by postgrey-1.27 at vger.kernel.org; Sat, 18 Apr 2015 12:32:11 EDT Date: Sat, 18 Apr 2015 18:31:49 +0200 From: Alban To: Paul Bolle Cc: Aban Bedel , linux-mips@linux-mips.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Jason Cooper , Ralf Baechle , Andrew Bresticker , Qais Yousef , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/14] MIPS: ath79: Add basic device tree support Message-ID: <20150418183149.69c0795b@tock> In-Reply-To: <1429340752.16771.120.camel@x220> References: <1429280669-2986-1-git-send-email-albeu@free.fr> <1429280669-2986-3-git-send-email-albeu@free.fr> <1429340752.16771.120.camel@x220> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 40 On Sat, 18 Apr 2015 09:05:52 +0200 Paul Bolle wrote: > On Fri, 2015-04-17 at 16:24 +0200, Alban Bedel wrote: > > > --- a/arch/mips/ath79/Kconfig > > +++ b/arch/mips/ath79/Kconfig > > > > +choice > > + prompt "Builtin devicetree selection" > > + default DTB_ATH79_NONE > > + help > > + Select the devicetree. > > + > > + config DTB_ATH79_NONE > > + bool "None" > > +endchoice > > This adds a choice block with one config entry. So what this achieves > is that DTB_ATH79_NONE will always be 'y', right? Besides I didn't > notice on a user of CONFIG_DTB_ATH79_NONE. So as far as I can see > this choice has no effect on the build. > > Why was this choice entry added? This menu is for boards that need a built-in DTB, as MIPS currently doesn't support appended DTBs it is the only way to load a DTB on boards stuck with a broken boot loader. But as no board has been added yet it only contain the entry for boards that don't need a built-in DTB, which do nothing as you pointed out. A board is then added in this menu in patch 14, for some reasons git send-email didn't send the whole serie at once :( Alban -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/